Problem/Motivation

This issue was found running the content moderation module. As described in the title, if the option to show a thumbnail is set for a field in the diff module settings, it is shown no matter what in split view.

Changes however are detected correctly, as was observed by removing the option to show thumbnails. Then, the field is removed if no changes were made and added with the picture's source if there were.

Steps to reproduce

  1. Install the Content Moderation module
  2. Install the Diff Module
  3. Make sure to configure the image field of the standard "article" content type in the diff settings so that thumbnails are shown
  4. Create a new article node with an image inside
  5. Create another revision of the same node with some text changed
  6. Navigate to the "revisions" view of the node
  7. Compare the two created revisions
  8. Select "Split view"
  9. You should now see the image thumbnails of the revisions, despite not changing them

Proposed resolution

Thumbnails should only be shown if changes have been made to the image field in question.

Comments

bahuma20 created an issue. See original summary.

sanket.addweb’s picture

I added a configuration for image revision status and resolved the display issue of images in revision diff.

sanket.addweb’s picture

Status: Active » Needs review
acbramley’s picture

Version: 8.x-1.x-dev » 2.x-dev
Status: Needs review » Postponed (maintainer needs more info)

This code has changed significantly in the latest 2.x version of this module. Can you please try testing this against the 2.x dev release?