Problem/Motivation

PHP 7.2 has deprecated the use of assert() on strings.

Proposed resolution

Replace strings.

Remaining tasks

  • Submit patch
  • Community/maintainer review

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 diff-replace_assert_on_string-3002285-2.patch1.96 KBchris burge

Comments

Chris Burge created an issue. See original summary.

chris burge’s picture

chris burge commented
Status: Active » Needs review
StatusFileSize
new diff-replace_assert_on_string-3002285-2.patch1.96 KB

Status: Needs review » Needs work

The last submitted patch, 2: diff-replace_assert_on_string-3002285-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

chris burge’s picture

chris burge commented
Status: Needs work » Needs review

There appears to be a problem with tests: 12:17:55 ERROR: No valid tests were specified.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#2946139: Remove usage of deprecrated each() function for PHP 7.2+ compatability

  • Alan D. committed 3bdb8ac on 7.x-3.x authored by Chris Burge 
    Issue #3002285 by Chris Burge: Remove usage of deprecated assert() on...
alan d.’s picture

alan d. commented
Status: Needs review » Fixed

Ta.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.