We noticed that the revisions are sometimes listing numbers in sub tags on the revisions page. Like this:

using-numbers-not-commas.png

Our concern is this will confuse our editors. I'm writing a patch for this. The patch begins by changing the subs to parentheticals. If I'm reading the next screen shot correctly ...

Cards 1 has change(s).
Card Column 1 which is inside Cards 1 has one change.
Card Column’s change is to its content.

explanation.png

I can explain this to the editors, but I think it can be better. It's quite difficult to create a readable pattern when there are paragraphs cards involved. I think this is an improvement over using sub tags, though.

parens-and-commas.png

CommentFileSizeAuthor
#2 entity_key-as-comma-2916136-2.patch633 bytesesod
diff-explanation.png33.77 KBesod
parens-and-commas.png94.83 KBesod
using-numbers-not-commas.png82.13 KBesod

Comments

esod created an issue. See original summary.

esod’s picture

esod commented
StatusFileSize
new entity_key-as-comma-2916136-2.patch633 bytes

Patch attached.

esod’s picture

esod commented
Title: Using $entity_key as a comma on the revisions page. » Using $entity_key as a comma on the revisions page
jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Status: Active » Needs review
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Needs review » Needs work

For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is a decidely old contribution, it might be good to confirm it is still an issue. Additinally, we'll need an MR opened and some tests.