Problem/Motivation

When i visit the comparison page (route: diff.revisions_diff), i can see the comparison.

But then i am a little bit lost. There is no possibility to get back to the overview page.

Proposed resolution

Add a "Back to overview" button

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 back_button_for-2853193-4.patch677 byteschr.fritsch
#2 back_button_for-2853193-2.patch720 byteschr.fritsch

Issue fork diff-2853193

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new back_button_for-2853193-2.patch720 bytes

Here is the patch

Status: Needs review » Needs work

The last submitted patch, 2: back_button_for-2853193-2.patch, failed testing.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new back_button_for-2853193-4.patch677 bytes

Maybe it's better to use javascript to get to the previous page

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

We shouldn't use JS for going back to the overview page. And we also need tests. :)

brunodbo’s picture

brunodbo
he/him
commented

Is there a common route for the entity version history page, i.e., a route we could point the back-link to? For nodes, we have entity.node.version_history, but not sure if that's a convention (entity.entity_type.version_history) across revisionable entity types.

the_g_bomb’s picture

the_g_bomb commented
Version: 8.x-1.x-dev » 2.x-dev
acbramley’s picture

acbramley commented

Re #6 - yes absolutely. Core has settled on that pattern with the generic revision UI.

the_g_bomb opened merge request !128

acbramley’s picture

acbramley commented

Should we close this in favour of #2954352: Local tasks for node not visible on diff.revisions_diff route? Local tasks seem like a more appropriate solution.

acbramley’s picture

acbramley commented
Status: Needs work » Postponed (maintainer needs more info)