Closed (fixed)
Project:
Diff
Version:
8.x-1.x-dev
Component:
Diff builder plugins
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Nov 2016 at 14:50 UTC
Updated:
17 Jan 2017 at 08:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
miro_dietikerWe should also create a separate issue about exif data export diff visualisation (on exiftool, if present) and connect the issues.
Comment #3
miro_dietikerComment #4
johnchqueFirst try, made images appear in the diff comparison.
Comment #5
miro_dietikerIs thumbnail guaranteed to exist? I doubt.
We need to decide if we are using some style that is configured or if we need to have this configurable such as with the diff plugin setting. But i would try to avoid that.
Comment #6
miro_dietikerSo checked, yeah the thumbnail image style can be deleted.
But the form display has the preview image style configured. We should simply use that one.
I guess, we should offer a new setting to display the image (default on), right?
About the check for 'thumbnail' -- shouldn't it be '#thumbnail'?
This is pretty invasive for DiffEntityComparision. I wonder how to deal with other advanced elements in diff.
Comment #7
johnchqueMade some changes, checking the code, if might need to rework the diff process so we can also add thumbnail for other file types.
Comment #9
miro_dietikerLet's first focus on picking the right image style. As stated, the preview style is configured in manage form display.
Then we can discuss about how much alteration makes sense and is acceptable in the current lifecycle.
Comment #10
johnchqueUsing that setting from the form display.
Comment #12
johnchqueSorry, added schema.
Comment #13
miro_dietikercompare_alt_field => show_thumbnail
And this shows why we need test coverage... ;-)
Why not just $result[$field_key]['#thumbnail']
And then we need to discuss the APIs and how we make this clean for other advanced cases.
Comment #14
johnchqueTrue, tests added.
Comment #16
miro_dietikerI'm kinda missing the image in the Unified fields layout.
Added some comments and committed!