Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
We have added an auto generated revision summary but we just display which fields have changed, might be much better to show which fields have been added / removed in each revision.
Proposed resolution
Add an Add / Remove-Delete text to the summary where needed.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screenshot from 2017-01-04 11-34-47.png | 20.58 KB | johnchque |
| #5 | display_add_delete-2824952-5.patch | 836 bytes | johnchque |
| #4 | Screenshot from 2016-11-14 10-11-37.png | 30.97 KB | johnchque |
| #2 | Screenshot from 2016-11-04 11-44-53.png | 43.81 KB | johnchque |
| #2 | display_add_delete-2824952-2.patch | 796 bytes | johnchque |
Comments
Comment #2
johnchqueThis would work. ;)
Comment #3
miro_dietikerWe could also here try to use a X - say an UTF-8 icon that is clearly identified as delete cross.
Would be nice if we had an inverse + symbol for adding too.
Best is if the icon is a bit different to the regular text, but not too dominant.
Some examples from the UTF-8 map: ⊕⊗ ➕➖⨁⨂⮾⮿
We might need to check if those are present in the popular systems.
Comment #4
johnchqueWhen using git --summary it displays written the changes made. Haven't found any other example where they use signs.
Comment #5
johnchqueIMHO looks good with this. :)
Comment #6
berdirNot sure I'm convinced about this and if it will really be understandable.
Adding the utf character through a json_decode() is pretty weird. Seems like we should be able to just put the actual UTF-8 character in there, I really hope in 2017 nobody has a problem with that anymore :)
Apparently PHP7 can do it like that only with PHP7: http://stackoverflow.com/a/34404876/560329
Comment #7
johnchqueShould we try with (Removed)/(Added) instead? That would look more self-explainable but it might get too long when there are many changes.
Comment #8
miro_dietikerAlso not convinced about that + / - look.
But i'm clearly agains "(Removed) / (Added)" because it will make the text much less readable.
We could think about putting a newline after every field instead a comma?
BTW Some people asked for both a what (field) plus a message... or explicitly to display the WHAT also when there is a manual message.
So what we create is just an additional summary and not replace the message at all.
Comment #9
miro_dietikerI would say we should do some new mockups with real data about this, to decide how it should work... :-)