Problem/Motivation

Currently the RevisionOverviewForm builds a list of node revisions with a code that is a lot redundant.

Proposed resolution

Refactor it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 diff_2804015_redundant_5.patch6.29 KBmiro_dietiker
#5 diff_2804015_redundant_5.interdiff.txt2.95 KBmiro_dietiker
#2 refactor_redundancy_of-2804015-2.patch6.28 KBtoncic

Comments

yongt9412 created an issue. See original summary.

toncic’s picture

toncic commented
Assigned: Unassigned » toncic
Status: Active » Needs review
StatusFileSize
new refactor_redundancy_of-2804015-2.patch6.28 KB

Refactored buildForm function in RevisionOverviewForm.

tbonomelli’s picture

tbonomelli commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/src/Form/RevisionOverviewForm.php
@@ -206,38 +206,17 @@ class RevisionOverviewForm extends FormBase {
+              'revision' => $this->setRevision($link, $username, $revision,
...
+                'select_column_one' => $this->setSelectColumn('radios_left', $vid, FALSE),

@@ -333,6 +291,58 @@ class RevisionOverviewForm extends FormBase {
+  public function setSelectColumn($name, $return_val, $default_val) {
...
+  public function setRevision($link, $username, $revision, $previous_revision_id ) {

Those are no real setters. Use some different term such as "build".

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new diff_2804015_redundant_5.interdiff.txt2.95 KB
new diff_2804015_redundant_5.patch6.29 KB

Renamed.

  • miro_dietiker committed 8b17871 on 8.x-1.x 
    Issue #2804015 by miro_dietiker, toncic92: Refactor redundancy of...
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.