Problem/Motivation

When building the diff comparison no field access check is made.

Proposed resolution

Add a access check, provide tests.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 check_for_field_access-2797279-2.patch3 KBjohnchque
#2 check_for_field_access-2797279-2-test-only.patch2.35 KBjohnchque

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
StatusFileSize
new check_for_field_access-2797279-2-test-only.patch2.35 KB
new check_for_field_access-2797279-2.patch3 KB

This should make it work better. :)

The last submitted patch, 2: check_for_field_access-2797279-2-test-only.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Priority: Normal » Critical

This is truly critical. :-)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Much nice. Committed :-)

It's possible a specific plugin doesn't consider field access, but ehough for me now. We test the default.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.