Problem/Motivation

As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.
Also remove unused imports.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#18 remove_file_tag-2755077-18.patch422 bytesjohnchque
#12 remove_file_tag_docblock-2755077-12.patch12.01 KBjohnchque
#12 interdiff-2755077-11-12.txt2.58 KBjohnchque
#11 remove_file_tag_docblock-2755077-11.patch10.72 KBjohnchque
#6 interdiff-remove-@file-docblock-2755077-4.txt1008 bytesrajeshwari10
#4 2755077-4.patch9.91 KBrajeshwari10
#2 2755077-2.patch10.09 KBrajeshwari10

Comments

rajeshwari10 created an issue. See original summary.

rajeshwari10’s picture

rajeshwari10 commented
Status: Active » Needs review
StatusFileSize
new 2755077-2.patch10.09 KB
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work 
  1. +++ b/src/Form/RevisionOverviewForm.php
@@ -1,13 +1,5 @@
- * This form displays all the revisions of a node and allows the selection
- * of two of them for comparison.

    Are these really useless? 

  2. +++ b/src/Tests/DiffRevisionTest.php
@@ -1,9 +1,6 @@
  * @file

    And you keep this?

rajeshwari10’s picture

rajeshwari10 commented
Status: Needs work » Needs review
StatusFileSize
new 2755077-4.patch9.91 KB

Please review.

I have done changes.

Thanks!!

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

If you provide an update, it would be great to also provide an interdiff. It helps to only review changes / deltas.

I will checkout once HEAD tests pass again.

rajeshwari10’s picture

rajeshwari10 commented
StatusFileSize
new interdiff-remove-@file-docblock-2755077-4.txt1008 bytes

Providing Interdiff.

Thanks!!

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Postponed

Quickly setting to postponed since this will cause conflicts with the other pending monster updates such as
#2708601: Allow per-field diff configuration
#2634212: Offer a diff controller for all entity types leveraging entity API module
Pretty sure there are more. Let's switch back to active and rebase once the big chunk is in.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Postponed » Needs review

Both blockers are committed now. Unpostponing.
I guess it needs a reroll?

Status: Needs review » Needs work

The last submitted patch, 4: 2755077-4.patch, failed testing.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Assigned: Unassigned » johnchque
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new remove_file_tag_docblock-2755077-11.patch10.72 KB

Made some other changes. :)

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
StatusFileSize
new interdiff-2755077-11-12.txt2.58 KB
new remove_file_tag_docblock-2755077-12.patch12.01 KB

Made some other changes, removed unneeded imports.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Issue summary: View changes
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Title: Remove @file tag docblock » Remove @file tag docblock and unused imports

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed, thx! :-)

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Fixed » Needs review
StatusFileSize
new remove_file_tag-2755077-18.patch422 bytes

Just realized that there are still some left. :/

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed again, with some additional fix...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.