Closed (fixed)
Project:
Diff
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
18 Dec 2015 at 09:21 UTC
Updated:
27 Jan 2016 at 23:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
snehi commentedComment #3
snehi commentedDone. Just moved the files.
Comment #5
dawehnerWell, you just remove files.
Comment #6
nidaismailshah commentedHere's the updated patch.
Comment #7
manjit.singhComment #8
joshi.rohit100Well instead of deleting and then creating the file, if you just do the move, that will make patch lighter and more readable.
Comment #9
snehi commentedComment #10
snehi commentedHere i moved the files with git mv command.
Comment #12
joshi.rohit100Still deleting and then re-creating the file. By move, I mean patch should mention that file has been moved.
Comment #13
alan d. commentedIt looks like that block module needs to be added as a dependency:
exception: [Uncaught exception] Line 130 of core/lib/Drupal/Core/Entity/EntityTypeManager.php:
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "block" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 130 of /var/www/html/core/lib/Drupal/Core/Entity/EntityTypeManager.php). Drupal\Core\Entity\EntityTypeManager->getDefinition('block')
Drupal\Core\Entity\EntityTypeManager->getHandler('block', 'storage')
Drupal\Core\Entity\EntityTypeManager->getStorage('block')
Drupal\Core\Entity\EntityManager->getStorage('block')
entity_create('block', Array)
Drupal\simpletest\WebTestBase->drupalPlaceBlock('local_tasks_block')
Drupal\diff\Tests\DiffRevisionTest->testRevisionDiffOverview()
Drupal\simpletest\TestBase->run(Array)
simpletest_script_run_one_test('1', 'Drupal\diff\Tests\DiffRevisionTest')
+dependencies:
+ - diff
+ - block
Which could magically resolve the other error (fingers crossed)
fail: [Other] Line 728 of core/scripts/run-tests.sh:
Unable to install modules node, diff, diff_test, block due to missing modules diff_test.
Comment #14
lhangea commentedComment #15
lhangea commentedThe test were failing because the test module was moved in the wrong directory. In fact the module needs to be moved outside of the module namspace i.e /src folder. Basically in the module root folder a new /tests folder is created and the module moved there.
Comment #16
dawehnerLooks perfect for me! This is indeed the location which makes it hidden by default.
Comment #18
lhangea commented