Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

dawehner created an issue. See original summary.

snehi’s picture

Assigned: Unassigned » snehi
snehi’s picture

Status: Active » Needs review
StatusFileSize
new1.85 KB

Done. Just moved the files.

Status: Needs review » Needs work

The last submitted patch, 3: 2637490-3.patch, failed testing.

dawehner’s picture

Well, you just remove files.

nidaismailshah’s picture

Status: Needs work » Needs review
StatusFileSize
new3.74 KB

Here's the updated patch.

manjit.singh’s picture

Assigned: snehi » Unassigned
joshi.rohit100’s picture

Status: Needs review » Needs work

Well instead of deleting and then creating the file, if you just do the move, that will make patch lighter and more readable.

snehi’s picture

Assigned: Unassigned » snehi
snehi’s picture

Assigned: snehi » Unassigned
Status: Needs work » Needs review
StatusFileSize
new3.77 KB

Here i moved the files with git mv command.

Status: Needs review » Needs work

The last submitted patch, 10: move-diff_test-to-tests-folder-2637490-10.patch, failed testing.

joshi.rohit100’s picture

Still deleting and then re-creating the file. By move, I mean patch should mention that file has been moved.

alan d.’s picture

It looks like that block module needs to be added as a dependency:

exception: [Uncaught exception] Line 130 of core/lib/Drupal/Core/Entity/EntityTypeManager.php:
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "block" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 130 of /var/www/html/core/lib/Drupal/Core/Entity/EntityTypeManager.php). Drupal\Core\Entity\EntityTypeManager->getDefinition('block')
Drupal\Core\Entity\EntityTypeManager->getHandler('block', 'storage')
Drupal\Core\Entity\EntityTypeManager->getStorage('block')
Drupal\Core\Entity\EntityManager->getStorage('block')
entity_create('block', Array)
Drupal\simpletest\WebTestBase->drupalPlaceBlock('local_tasks_block')
Drupal\diff\Tests\DiffRevisionTest->testRevisionDiffOverview()
Drupal\simpletest\TestBase->run(Array)
simpletest_script_run_one_test('1', 'Drupal\diff\Tests\DiffRevisionTest')

+dependencies:
+ - diff
+ - block

Which could magically resolve the other error (fingers crossed)

fail: [Other] Line 728 of core/scripts/run-tests.sh:
Unable to install modules node, diff, diff_test, block due to missing modules diff_test.

lhangea’s picture

Assigned: Unassigned » lhangea
lhangea’s picture

Status: Needs work » Needs review
StatusFileSize
new3.74 KB

The test were failing because the test module was moved in the wrong directory. In fact the module needs to be moved outside of the module namspace i.e /src folder. Basically in the module root folder a new /tests folder is created and the module moved there.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Looks perfect for me! This is indeed the location which makes it hidden by default.

  • lhangea committed f091f3c on 8.x-1.x
    Issue #2637490 by snehi, lhangea, nidaismailshah: move the diff_test...
lhangea’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.