I would like to suggest 2 improvements to the file diff comparison.

1) It would be nice to be able to open the file by clicking on it so that you can compare the difference more easily.

2) It would be nice to be able to include the file size in the comparison so it is more apparent than just an FID change of what happened.

CommentFileSizeAuthor
#3 diff-2101391-3-file-and-image-property-separator-options.patch3.44 KBAlan D.
#3 diff-file-property-separator-options.png5.12 KBAlan D.
#1 diff-attachments-before.png16.25 KBhaydeniv
#1 diff-attachments-settings-after.png33.99 KBhaydeniv
#1 diff-attachment-settings-before.png28.58 KBhaydeniv
#1 diff-attachments-after.png29.68 KBhaydeniv
#1 2101391-file-entity-improvements.patch2.75 KBhaydeniv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

haydeniv’s picture

haydeniv CreditAttribution: haydeniv commented
Status: Active » Needs review
FileSize
2101391-file-entity-improvements.patch2.75 KB
diff-attachments-after.png29.68 KB
diff-attachment-settings-before.png28.58 KB
diff-attachments-settings-after.png33.99 KB
diff-attachments-before.png16.25 KB

Here is the start of this. I could not get the linking to the file entity because everything is converted to text and so the hyperlink does not link because the filename changes in the hyperlink. Maybe someone else wants to take a stab at getting the linking to attachments to work. If it's too much trouble I can just do this with the file size improvements.

Settings Before:
diff-attachment-settings-before.png

Result Before:
diff-attachments-before.png

Settings After:
diff-attachments-settings-after.png

Result After
diff-attachments-after.png

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented

How about just this?

$diff_items[$delta] = implode(variable_get('diff_file_property_separator', '; '), $output);

Which you would run this once to set:

variable_set('diff_file_property_separator', "\n");
Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
FileSize
diff-file-property-separator-options.png5.12 KB
diff-2101391-3-file-and-image-property-separator-options.patch3.44 KB

Or even better, a UI too ;)

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Status: Needs review » Fixed

Pushed to dev bd5831a

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.