I tried the latest diff 7.x-2.x code, but I'm getting a 500 internal server error when viewing a specific revision. Looking at my PHP error logs, here's the error message I'm getting:

PHP Fatal error: Call to undefined function drupal_strpos() in /Users/drupal/sites/all/modules/contrib/diff/DiffEngine.php on line 1275

It pretty much makes Diff unusable for me right now.

Thoughts?

Thanks,
Ben

CommentFileSizeAuthor
#3 drupal_strpos_to_strpos-1251068-1.patch1.92 KBmas5d2
#2 drupal_strpos_to_strpos-1251068-1.patch1.92 KBmas5d2

Comments

Hakaku’s picture

Hakaku commented

I'm not sure how this error got introduced, but you'll have to replace all instances of drupal_strpos with just strpos. There should be 4 of them in the file DiffEngine.php on lines 1243, 1253, 1275 and 1279.

mas5d2’s picture

mas5d2 commented
StatusFileSize
new drupal_strpos_to_strpos-1251068-1.patch1.92 KB

Patch to change drupal_strpos to strpos.

mas5d2’s picture

mas5d2 commented
StatusFileSize
new drupal_strpos_to_strpos-1251068-1.patch1.92 KB

Patch to change drupal_strpos to strpos.

realityloop’s picture

realityloop commented
Status: Active » Fixed

Applied to dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.