Closed (fixed)
Project:
Diff
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
20 Jul 2011 at 22:37 UTC
Updated:
7 Oct 2011 at 23:01 UTC
Jump to comment: Most recent file
Comments
Comment #1
katbailey commentedPatch attached.
Here's a screenshot: https://skitch.com/katbailey/fk9e6/diff-new-and-removed WIthout this patch those changes wouldn't show up.
Comment #2
realityloop commentedAdded to dev, thanks for the patch.
Comment #3
katbailey commentedYay - just saw it made it into the 2.0 release, awesome! :-)
What's not awesome is that I hadn't tested it properly with preview changes, and when I did the changes involving removed field values were not showing up. The problem is that the new version of the node still has the
$langcodekey set for the field, even though it's an empty array. This gets blown away when the node gets saved, which is why it works fine when you do a full revision diff.Here's a follow-up patch that checks that it's not empty.
Comment #4
realityloop commentedApplied in dev, thanks again