Searching through the file for every request is heinously slow.

If the word list was in the database using the number as the primary key of the table, it would be considerably faster.

This would probably be something I'd pick up in a manual code review.

Comments

migmedia’s picture

migmedia commented
Version: » 7.x-1.0
Assigned: Unassigned » migmedia
Status: Active » Closed (won't fix)

Yes for sure it would be faster.

But I don't want a large table for static-data (=readonly) only used in single places. The intention of this module is to show a block to advise the user when (s)he thinks about a new password.
So the file-parsing is used just at url "user/*/edit" or "user/". Imho the performance penalty is tolerable.