I extracted DHTML 6.x.4.x-dev and got these code issues while running update.php script-

An error occurred. http://www.schulmansites.com/squeezepage/update.php?id=2&op=do
Fatal error: Call to undefined function drupal_theme_rebuild() in /home1/schulman/public_html/squeezepage/modules/dhtml_menu/dhtml_menu.install on line 145

and

The update process was aborted prematurely while running update #7101 in dhtml_menu.module

Not sure what this is - but wanted you to know about it - please let me know if this is a new bug or if there is a fix. . .

Thanks
Aaron

CommentFileSizeAuthor
#2 dhtml_menu-956962-2-updates.patch814 bytescburschka

Comments

cburschka’s picture

Priority: Major » Critical
Status: Needs review » Fixed

This is indeed a bug, and a rather silly one on top of it.

6.x-4.x is a backport from the 7.x-1.x version (which is nearly a rewrite in some areas). The 7.x-1.x upgrade path has been duplicated in 6.x-4.x, so that you get basically the same updates whether you upgrade to 6.x-4.x or 7.x-1.x. Unfortunately, one of these involves rebuilding the theme registry (which may be superfluous in retrospect, since caches are automatically cleared during updates). This is done with drupal_rebuild_theme_registry in D6, but with drupal_theme_rebuild() in D7. I forgot to change the call while copying.

I have committed the patch attached, since it's a fairly obvious and critical fix.

Don't worry about being stranded in a broken state now. As soon as the -dev package is automatically rebuilt (in less than a day) you can download it and then run the update again.

cburschka’s picture

StatusFileSize
new814 bytes

Here's the patch. It's already in, but I don't like committing to CVS without leaving a trail in the issue tracker.

Status: Fixed » Closed (fixed)
Issue tags: -bug, -DHTML

Automatically closed -- issue fixed for 2 weeks with no activity.