Closed (fixed)
Project:
DHTML Menu
Version:
5.x-1.0
Component:
User Interface
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
11 Apr 2007 at 13:41 UTC
Updated:
21 Aug 2007 at 08:03 UTC
Jump to comment: Most recent file
Comments
Comment #1
cburschkaDue to the way this module uses recursion, adding the class to li elements would be very difficult to implement.
However, a $toplevel flag exists in the function that generates the ul element, so adding this class to the root list is trivial.
In CSS, this just means root elements can't be referenced with
li.menu-root-element, but have to be referenced withul.menu-root li, so it works just as well.Patch attached.
Comment #2
cburschkaRerolled for 5.x-1.x.
This change doesn't actively change any behavior (aside from providing a menu-root class for CSS files to work with), so barring code-style issues this is RTBC.
Comment #3
cburschkaForgot the attachment
Comment #4
cburschkaCommitted to DRUPAL-5. I'm making a patch for D6 now.
Comment #5
cburschkaHere's the patch for D6.
Note that the CSS class of the menu ul touches on another issue recently fixed for D5, where dhtml_menu's JS caused a conflict. The solution involved adding a dhtml_menu class to the element.
This patch does not add said class. That will be done in the porting of, um... of whatever issue described this. (This is what #node references in the commit messages are for...)
Comment #6
cburschkaI've committed this a while ago, but evidently forgot to mark it fixed.
Comment #7
(not verified) commented