Problem/Motivation

The following standard errors are present in the module currently:

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: /home/gue/patches/default_widget/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------
  4 | WARNING | [ ] Line exceeds 80 characters; contains 99 characters
  6 | WARNING | [ ] Line exceeds 80 characters; contains 292 characters
 32 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
 34 | WARNING | [ ] Line exceeds 80 characters; contains 119 characters
 40 | ERROR   | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: /home/gue/patches/default_widget/src/Form/DefaultWidgetSettingsForm.php
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------
 69 | WARNING | Line exceeds 80 characters; contains 85 characters
-----------------------------------------------------------------------------


FILE: /home/gue/patches/default_widget/src/Form/DefaultWidgetFieldStorageAddForm.php
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------
 29 | WARNING | Line exceeds 80 characters; contains 84 characters
------------------------------------------------------------------------------------


FILE: /home/gue/patches/default_widget/config/schema/default_widget.schema.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------


FILE: /home/gue/patches/default_widget/default_widget.install
-----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------
 33 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 44 | ERROR   | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

Time: 72ms; Memory: 8MB

Thankfully they're all very minor spacing and character limit related. I'm applying this module for the Drupal Security Advisory Policy though, so those need to be fixed.

Remaining tasks

Fix all coding standard errors detected.

Comments

gueguerreiro created an issue. See original summary.

gueguerreiro’s picture

gueguerreiro
Primary language Portuguese, Portugal
Location Lisboa
commented
Assigned: gueguerreiro » Unassigned
Status: Active » Fixed

Made commits for both the 2.x and 1.x branches.

No new release will be created yet, as those are all minor improvements to code clarity, but no actual code was changed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.