CommentFileSizeAuthor
#4 correction-and-improvement-settings-form-3108276-4.patch3.04 KBmatio89
#4 Screen Shot 2020-01-23 at 13.09.46.png55.49 KBmatio89

Comments

matio89 created an issue. See original summary.

matio89’s picture

matio89 commented
Status: Needs review » Needs work
matio89’s picture

matio89 commented
Title: Site and Secret keys must be require, correction and improvement for settings form in term of adding missing descriptions and required true » Site and Secret keys must be require, correction and improvement for settings form in term of adding missing descriptions
Issue tags: -Correcting issues and improving Settings form
matio89’s picture

matio89 commented
Title: Site and Secret keys must be require, correction and improvement for settings form in term of adding missing descriptions » Site and Secret keys must be required, correction and improvement for settings form in term of adding missing descriptions
StatusFileSize
new Screen Shot 2020-01-23 at 13.09.46.png55.49 KB
new correction-and-improvement-settings-form-3108276-4.patch3.04 KB

Hi,

I remarked missing code in the settings form.

- Site and Secret keys must be required.
- Each field in the form should have a description.
- The badge position would be better to be a select list.

I corrected and attached the screenshot of the issue and the patch.

Review and let me know.

matio89’s picture

matio89 commented
Status: Needs work » Needs review

  • matio89 committed b83008b on 8.x-1.x 
    Issue #3108276 by matio89: Site and Secret keys must be required,...
matio89’s picture

matio89 commented
Version: 8.x-1.0 » 8.x-1.x-dev
Status: Needs review » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.