Hi,

Other modules using libraries are sometimes using an example makefile to help people download the library. Why not do the same here?

Comments

simon georges’s picture

Status: Active » Needs review
StatusFileSize
new359 bytes

Patch provided.

asherry’s picture

How do you use it with just one module, or is it for a new distribution?

simon georges’s picture

Well, if you're using only this module, at least you can download the library directly (by using drush make --no-core d3.make.example), and if you're building a distribution, you may directly copy this lines into your makefile. It's just an help for people using the module, not at all an obligation, but as several modules have already adopted this help, I'm thinking it should be enforced everywhere.

asherry’s picture

Status: Needs review » Needs work

Can you submit another patch and add that explanation to the README.txt file? That sounds great.

Also what other modules are doing this? I'd like to check those out.

simon georges’s picture

I can name of the top of my head at least Colorbox, Geofield, Mailchimp (I think colorbox provides a drush command for it too (as well as other modules).
I'll submit another patch.

simon georges’s picture

Status: Needs work » Needs review
StatusFileSize
new1020 bytes

Is this one along the lines of what you're expecting?

asherry’s picture

Status: Needs review » Fixed

Yeah that looks great, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

asherry’s picture

Project: » d3.js
Version: » 7.x-1.x-dev
Issue summary: View changes