adan [adan]

Hello, and thank you for applying for a CVS account. I am adding the review tags.

Hi,

I had a little look to get the ball rolling.

Some good things for sure:
1) Hey, you're here wanting to contribute!
2) At a glance, it looks good!
3) I see lots of comments
4) The code uses t() for translators.
5) SQL uses {} for table names, and % for replacement parms
6) Install cleans up

A few things to work on for now:

1) The code (I guess) is great, but when you are submitting to the community it is so that other people can use it, so it needs both great documentation for end users and for other coders. Please add:
i) a README.txt (full guidance for users of your module)
ii) documentation for every function (full guidance for programmers wanting to change your module)

2) Make the name of the module consistent:
In the .info file I would write:
name = WFSA, Web Form Submission Attachments
I looked for "wfsa" in the list of modules and couldn't find it, so I had to go back and read the "name" field to find out what it was called; a user with less knowledge might have struggled.

3) Remove " // TODO: avoid calls to private functions" from this "completed" module (we all know a module is never complete, and that dev versions may have this, but this is supposed to be a user-ready version)

4) I think that t() is not needed on titles. Can someone clarify please?

See you later!

I am changing status as per previous comment.

Hi,

" 4) I think that t() is not needed on titles. Can someone clarify please? "

You are right drupalshrek, the t() is not needed on the titles if it is called from the menu hook as it passes the title string through t() by default.

If you want to have your own custom function for the translation then set
'title callback' => 'my_custom_function', in the menu hook.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

As per previous comment, I am setting this issue as Won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.