mackh [mackh]

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

You shouldn't be bundling third-party code with your module. Instead, your README.txt should give instructions for where and how to obtain that code. This third-party code cannot go into Drupal CVS because it is not GPL.

Your third-party code has requirements of cURL, PHP 5, and SSL. The PHP 5 requirement should go in your .info file. Presence of cURL and SSL should be checked in your .install file.

I did not run Coder, but it looks like this module follows all coding standards.

You should remove all that .svn and _macoxs stuff from the .zip file.

Hi,

Thanks very much for your work and support of the Drupal community. I'm personally happy to see a contribution for Ubercart :-) - especially additional payment processing integration which at times is a "pain point" for prospective users who don't have the budget for such on their own.

I don't have a way to test this myself, but it looks pretty awesome from what I can see! I do think the function names in the install file (and a related text change) would be needed before doing a release when the time comes.

And I personally wanted to suggest consideration of adding a brief hook_help() even if the information is brief or mostly points to users back to the ReadMe file - which has a lot of great information. I realize this is more useful for some modules - especially ones with many settings - than others, but I think it's a "nice touch" to have that in there.

Thanks again; I hope you have your CVS account soon; and I look forward to seeing this addition to Ubercart.

Sincerely,

Matt Winters

Hi mackh,

Your install file still has the moneris function references in it:

- uc_moneris_requirements
- uc_moneris_uninstall

Also, there is an IATS module that can be found here : http://drupal.org/project/uc_iats perhaps you could offer to co-maintain?

I also wanted to mention that your readme is much better then that of the project listed above.

cheers.

I am changing status as per previous comment.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.