mossy2100 [mossy2100]

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

Please read http://drupal.org/coding-standards and the use http://drupal.org/project/coder to check your code and correct it.

1. Don't put "< p >" inside t().

$form['instructions'] = array(
    '#type' => 'markup',
    '#value' => t("<p>Select which classes you want to generate for your content types.</p>" .
      "<p>If the base class already exists it will be overwritten. If the derived class does not " .
      "exist then a stub will be created, but if it does exist it will not be overwritten.</p>" .
      "<p>Core classes for nodes, users, terms, dates, etc. will only be generated if they don't " .
      "already exist, or they need to be updated.</p>"),
  );

2. No, no, no, not a good way.

  // CSS:
  $form['css'] = array(
    '#type' => 'markup',
    '#value' => "<link type='text/css' rel='stylesheet' media='all' href='/".
      drupal_get_path('module', 'classes') . "/classes_generate_form.css' />",
  );

Look at this http://api.drupal.org/api/drupal/includes--common.inc/function/drupal_ad...

3. Remove commented code.

  // If the base class exists, select it for regeneration by default:
  //    if ($base_class_exists) {
  //      $selected[] = $type;
  //    }

4. Put the outputed text into t(), "Yes", "No" and "Generate".

  $form['class_exists'][$type] = array('#value' => $class_exists ? 'Yes' : 'No');

  $form['base_class_exists'][$type] = array('#value' => $base_class_exists ? 'Yes' : 'No');

  $form['submit'] = array(
    '#type' => 'submit',
    '#value' => 'Generate',
  );

5. drupal_add_js() instead!

      // Add some JS:
      $form['js'] = array(
        '#type' => 'markup',
        '#value' => "<script type='text/javascript' src='/" . drupal_get_path('module', 'classes') . "/classes-property-name.js'></script>"
      );

6. Missing CVS header in classes.install.

7. You might want to use check_plain on some text you puts out in HTML.

- - - - -

Havn't checked all the code, so there could be more similar errors in more places so please look over all your code and correct them.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

This queue is not used anymore. Please see Migrating from CVS Applications to (Git) Full Project Applications, and Applying for permission to create full projects to understand how to proceed.