CVS edit link for hymanroth

I created a module and want to share it.
CommentFileSizeAuthor
#9 pathlockdown.zip4.86 KBhymanroth

Comments

avpaderno’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)
hymanroth’s picture

Status: Closed (won't fix) » Postponed (maintainer needs more info)

Thanks for refusing my CVS account request.

Assuming you're interested, here's the module I wanted to share http://github.com/hymanroth/Path-Lockdown

hymanroth’s picture

Status: Postponed (maintainer needs more info) » Needs review
avpaderno’s picture

Status: Needs review » Closed (won't fix)

Hello, and thanks for applying for a CVS account.

Unfortunately, you didn't do what reported in http://drupal.org/cvs-application/requirements, which is the page where you found the link to apply for a CVS account; you didn't also followed what reported in the form where you entered the motivation of your application, which states:

A message providing information about yourself and your planned contributions.

  • Describe what modules, themes, or translations you want to maintain and why.
    Please provide as much information as possible along with appropriate links if available.
  • If your contributions implement existing functionality explain why you want
    to duplicate it or why you cannot extend any of the existing projects.
  • If you have been asked to co-maintain an existing module, please link to
    an issue where the current maintainer explicitly states so.
  • More information, the better.

Failure to provide a well written motivation message or a conflict with the CVS application guidelines will result in your application being declined.

The following message should have been shown to you:

The Concurrent Versioning System (CVS) is a software development tool used to manage programs and files for the Drupal project. It is available to volunteers with experience in software development, translation, theming or documentation who wish to participate in the project.

A CVS account is not required to contribute patches to the Drupal project or community contributed projects. Anonymous access to the Drupal CVS repository is available which can be used to accomplish this. Please peruse the CVS handbook and patch guide for more information.

If you are an open source software developer, themer, translator or documentation writer, please use the form below to request access to Drupal's CVS repository. Prior to applying, please ensure that:

The use of the Drupal Contributions Repository (DCR) is regulated by the Drupal Contributions Repository - Terms of services (TOS).
By using the DCR, you are accepting, and agreeing to the TOS.

hymanroth’s picture

Status: Closed (won't fix) » Needs review

I wrote a small and simple module which I find very useful. I wanted to give something back to the community by sharing it. That is all.

It says on drupal.org "Contributors are strongly encouraged to host at drupal.org rather than elsewhere (GitHub, BitBucket, your personal site, etc.)"
That is all I am trying to do.

If you had clicked on the link I supplied you would have read:

$Id$

Path Lockdown module by David Semeria
=====================================

DESCRIPTION
Path Lockdown generates a full list of all paths present on a Drupal site, and shows whether a given user can access them or not.

Paths are broken down into two main categories: system and site.
System paths are those provided by Drupal core and any third-party modules.
Site paths are those which are not system paths.
If you set-up your settings.inc file correctly, only your site-specific paths will be appear under 'site'.

QUICK START
Create a folder in sites/all/modules and put the Path Lockdown files in it.
Enable the Path Lockdown module. It appears under 'Development' in the module list.
Choose any url on your site and append this exact query: ?pl=pwd (you can change this later)
You should now see a page containing the full Path Lockdown output for the current user.
You can switch users (for example using the devel module) and the page will refresh.
There is no need to re-enable the module for each user.
To turn-off the module just append the following query: ?pl
Path Lockdown uses a session cookie for access control, and so closing your browser will also cause it to be disabled.

UID MODE
Instead of logging in/out as a specific user, you can also pass Lockdown a user id (uid)
With Path Lockdown enabled, type in the url: yoursite.com/pl/uid (where uid = the user id you want to verify).
The module makes sure the uid is valid before processing, so don't worry about typos.

CUSTOMIZATION
For security purposes you can change the activation query (?pl=..), the activation password, and the path used by Path Lockdown (yoursite.com/pl).
See default_settings.inc for details.

Since no two Drupal installations are identical, you will almost certainly have to add to the system paths in your settings.inc.
See default_settings.inc for details.

You can also change the output format by specifying your own HTML tags.

Why make it so difficult for people who want to give something back to the community?

jsr47’s picture

No one is making it difficult - just read the instructions provided, and follow them. There are lots of modules and themes to review by a team of volunteers - having a process makes things run more smoothly.

sorry, I should never do anything in the morning before coffee...

hymanroth’s picture

You're right about the coffee.

avpaderno’s picture

Status: Needs review » Postponed (maintainer needs more info)

The archive containing the proposed module has not been attached in a comment here.

hymanroth’s picture

StatusFileSize
new4.86 KB

Archive attached

jsr47’s picture

Status: Postponed (maintainer needs more info) » Needs review

Don't forget to reset the 'needs review' status when you make a change!

svendecabooter’s picture

Comments after browsing through the code a bit:

  • Please run your module through Coder module to make sure it applies to the Drupal coding standards. Specifically you should set your editor to use 2 spaces instead of tabs.
  • Haven't gone into the functional details of the module, but check if it's possible to let users change the settings through the UI on a Site Configuration page for your module.
  • Code that outputs HTML should go through a theme() function (eg. _plockdown_gen_summ)
  • Please add comments above each function to indicate its functionality
  • General remark: the used function names and variables are not very descriptive, and might not invite other people to build upon your code if it's not clear what these functions do
hymanroth’s picture

Thanks for your comments svendecabooter.

I wrote the module for my own personal use, but since I find it really useful I thought I would share it.
It's very 'quick and dirty' - but it does do what it says on the tin.
I don't know if you've had the chance to run the module on an actual Drupal installation, but some of the results can be very revealing.
For example, ctools has three paths which are open to authenticated users: '/test', '/test2' and '/test3'.
This type of information could be useful to the security team.

I will fix up the comments and the func / var names in the next few days.
However, I don't have time to incorporate the settings UI or theme functionality you suggested.

The module is intended purely for developers, and so, while UI settings would be useful, they're probably not essential.
And since you can customize the output format from the settings file, there is no real need to go through theme().

I hope these two last issues are not deal breakers because that would be a pity.
If I had time I would implement all of your suggestions but I am, unfortunately, very, very busy.

avpaderno’s picture

Issue tags: +Module review

And since you can customize the output format from the settings file, there is no real need to go through theme().

Theme functions should be used whenever there is HTML output; the use of theme functions don't depend from the presence of a configuration file. What is the vantage of using a theme function?

If I had time I would implement all of your suggestions but I am, unfortunately, very, very busy.

That is not the kind of reply I would expect from who is applying for a CVS account. If there is no much time to dedicate for a CVS application, then I wonder if there would be enough time to dedicate to the project, when users will report bug reports.

I am changing status as per comment by svendercabooter.

hymanroth’s picture

I give up. I can't say I didn't try.
Oh, and a quick message for kiamlaluno: pirla.

avpaderno’s picture

Status: Needs review » Closed (won't fix)

@hymanroth: You should be also brave to say it in English, but I guess you will not do it.

avpaderno’s picture