CVS edit link for ManuAdam

I have developed a new module called Dbstylo, which, I am sure, all Drupal users will love to use as it provides easy ways to add beautiful style elements like colorful rounded boxes and alert, info, warning and code displays in the content. Besides, users can also easily add colorful buttons within the content or separately -- all these can be possible by just writing a small string like {dbstylo_} and then placing text in between. I have checked and ensured that module is fully functioning now and there is no other such contributed module at present. So there is no repetition of work either.
CommentFileSizeAuthor
#4 dbstylo.zip153.68 KBManuAdam
#3 dbstylo.zip153.68 KBManuAdam

Comments

stevenpatz’s picture

Status: Postponed (maintainer needs more info) » Needs review
avpaderno’s picture

Status: Needs review » Postponed (maintainer needs more info)

Hello, and thanks for applying for a CVS account.
As per requirements, the motivation should be expanded to contain a description of the features of the proposed module, and a comparison with the existing projects. The given description is not clear to me. Does the module implement a filter?

Then, as reminded in the email automatically sent you, you need to attach in a comment here the archive containing the code for review.

ManuAdam’s picture

StatusFileSize
new153.68 KB

Here is my Dbstylo module, which I am uploading as zip file. I am contributing a module first time and so I am confused also about the right procedure and may commit some silly mistakes. I apologize for that in advance. I hope and wish that Drupal experts would find the Module working and useful enough to be added in Drupal's large assets of contributed modules.

ManuAdam’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new153.68 KB

Oh Sorry, In my earlier reply I forgot to change the status to Needs Review. hence I am sending the zip file of my Dbstylo module again. Sorry for the mistake, Please o be kind enough to review it. Thanks.

sun’s picture

How does this module compare to the existing modules?

ManuAdam’s picture

Is there any existing module like this. I have checked many times.. all other modules like Texy, Typogrify or Textiles perform different sets of functions and most depend on external libraries. At least there is no such Drupal module at present which present TEXTS in beautiful stylish boxes or under pre-built css formats. Besides, this module works seemlessly without any conflict. But I must admit that Drupal has such large number of contributed modules, I cant say with full conviction that there is no such module doing similar task. But when after all my search I couldn't find any, then only I'd decided to go ahead and do it. I hope Dbstylo is unique in this respect.

avpaderno’s picture

Status: Needs review » Needs work

See also comment #2. To me is still a mystery what the purpose of the module is.

ManuAdam’s picture

Hello,thanks for a quick reply. i am sorry to say that it's not such a thrilling mystery which you can really enjoy, but just a simple drupal module. And of course, it uses filter . As I had explained earlier it adds some design elements to the content.

In fact. this module is very well in action at my production site : www.drupalbest.com , where you can see the use of module. Because, the site is still in construction stage, some part of it may appear to be abrupt, but you can very well check the Dbstylo module in action. Here, I am also telling you briefly how it works, then perhaps you can have some idea.

After enabling the filter, if anybody writes : {string} My text {/string} then that "My text" will be displayed in various different stylish ways. presently Dbstylo module provides about 15 such built-in strings. Suppose you write dbstylo_rounded4 in the place of string, then this My text will be displayed in Rounded red color box. for rounded3 it is blue color rounded box. Similarly one can display Alert, Info, warning, sticky and code view in special style. That is the idea of this module. As such, to the best of my knowledge no existing drupal module provides such functionality out of box.

AthenaAdam’s picture

ManuAdam’s picture

Now it is almost a week and no communication. I am still waiting in darkness without any clue.

avpaderno’s picture

Status: Needs work » Needs review
sun’s picture

1) Please understand that all CVS applications are reviewed by volunteers and every single review takes quite some time.

2) It looks like you have two user accounts? Which of both can we block? AthenaAdam, I guess?

avpaderno’s picture

@sun: It doesn't seem the accounts are for the same person; even if it would be true, there is nothing that says one user cannot have two accounts.

ManuAdam’s picture

Thanks kiamlaluno. I m sincerely obliged. I am also sorry for this faux pas as I was not aware of the rule. Sun, I apologize for my mistake to ask my co-worker athena to check here whether there is any reply or not. I take the blame and request you not to penalize here for my fault. She looked here on my request. She is a big time Drupal addict and it wont be right to block her account. If you want you can block my account as it is my fault basically. Thanks again.

avpaderno’s picture

@ManuAdam: We don't block an account because a user asked about a CVS application. sun thought both the accounts were yours.

joachim’s picture

Status: Needs review » Needs work

Quick eyeball review:

- there's a lot of messy code here, with indentation all over the place which makes it hard to even see where classes end. I'm not even entirely sure why you need OO here anyway.

- some of the code in the .module file appears to duplicate the files in /includes.

- the module file's doc header appears to be copied from the hook_help doc header, which makes no sense

- you have a hook_perm but never use its permission

- in general, please review the format for function doc blocks: they don't need a @desc

- your hook_help has far too much stuff about credits and installation

- your dbsprocess defines a huge list of variables. it might be a better pattern to define nested arrays, which a later version could allow either devs or admins to extend with hooks and UI respectively.

- finally, I'm confused about the name! What does dbstylo mean? Why 'db' -- that suggests database to an English speaker and there's nothing about the database layer here.

ManuAdam’s picture

hello sorry, I just now saw ur reply msg. Presently i am busy in shooting a few documentary films. Hope to get back by month end. After that I will do as you suggest and clean up the codes removing redundant elements and make it more drupal compatible. Thanks. So far as name is concerned.. it stands for dbstylo= drupalbest stylo... Well if u feel it is wrong or against some rule, we can always change it. Thanks Manu Adam

avpaderno’s picture

Status: Needs work » Closed (won't fix)

I am closing this application due to lack of activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes

Please read the following links as this is very important information about CVS applications.