alex.a [filopodaros]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

Comments, strings used in the user interface, and variable names should be in English. User interface strings should be translatable through t(), which require the source string to be in English; comments, and variable names should be in English to not stop who is able to provide patches for the module to contribute.

 * 
 * This module is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, version 2 of the License.
 * This module is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 * 
 * You should have received a copy of the GNU General Public License
 * along with this module.  If not, see <http://www.gnu.org/licenses/>.

Afaik you should remove it, the d.o script automatically creates the license.txt for every release.

function podi_has_english( $name ) {
  $len = strlen( $name );
  for( $i = 0; $i < $len; $i++) {
    $c = $name[$i];
    if ( ('a' <= $c && $c <= 'z') || ('A' <= $c && $c <= 'Z')) {
      return true;
    }
  }
  return false;
}

You should use the offiical code style of drupal, so for example TRUE instead of true, or function podi_has_english($name) {

For more details on how the code should be formatted, see http://drupal.org/coding-standards.

I will review the code tomorrow, or the day after.

1.         $msg = 'The username %user is not valid.';
           $msg = t($msg, array('%user' => $name));
           form_set_error($form_id, $msg);
   

   The first argument of t() must be a literal string; differently, the script that extracts the string to translate to create the translation template will not be able to extract the string, which would not be translatable (if not in the case another module uses the same exact string, but it's rather difficult it happens, when the string is dynamically changed).
   The first argument of form_set_error() is the identifier of the form field containing the error, not the form ID.

   Then, the three lines of code can be rewritten in only one.

2. The code should use the Drupal Unicode functions, when available. The complete list is probably reported in http://drupal.org/coding-standards.

3. package = www.podilates.gr
   version = 6.x-0.5.1
   

   The package is used for a different purpose, and it's not necessary for a single module. The version line must be removed, as it is already added by the packaging script, and having two lines like that confuses the update manager, which could not pick up the correct version.

1. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted.

2. function podi_decode_utf8($s) {
     $len = strlen($s);
     $codes = array();
     $n = 1;
     for ($i = 0; $i < $len; $i += $n) {
       $c = ord($s[$i]);
       $v = $c;    
       if (($c & 0x80) == 0) {
         // first bit is 0:  1-byte ASCII character
         $n = 1;
       }  else if (($c & 0xe0) == 0xc0) {
         // first 3 bits are 110:  2-byte character
         $n = 2;
         $v = $c & 0x1f;
       }  else if (($c & 0xf0) == 0xe0) {
         // first 4 bits are 1110:  3-byte character
         $n = 3;
         $v = $c & 0xf;
       }  else if (($c & 0xf8) == 0xf0) {
         // first 5 bits are 11110:  4-byte character
         $n = 4;
         $v = $c & 7;
       }
       for ($j = 1; $j < $n && $i+$j < $len; $j++) {
         $c = ord($s[$i+$j]);
         $v = $v * 64 + ($c & 0x3f);       
       }
       $codes[] = $v;
     }
     return $codes;
   }
   

   Why isn't the function doing like the function drupal_convert_to_utf8() is doing?

3. /**
    * Implemementation of hook_user
    */
   function podi_user($op, &$edit, &$account, $category = NULL) {
     if ($op == 'validate') {
       if ($edit['form_id'] == 'user_register') {
         // only prevent user registration.  User administration is not subject to this validation.
         $name = $edit['name'];
         module_load_include( 'inc', 'podi' );
         if (podi_is_mixed_language($name)) {       
           form_set_error('name', t('The username %user is not valid.', array('%user' => $name)));
         }
       }
     }
   }
   

   I am not sure that is the correct way to validate the username; the code should probably use hook_form_alter(), or hook_form_FORM_ID_alter().

4. The comment for hook implementations should be Implements hook_user()., in example. The comments for hooks report Implemementation of.

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.