CVS edit link for trashgenerator

Hello, dear Developers.

I have developed module for Drupal and want to share it with other Drupal users. This module integrates with Yandex Market service. http://market.yandex.ru . Yandex Market is a catalog of products from different on-line stores. It is a convenient way to offer products from your on-line store for users who want to buy them via the Internet.
If you have on-line store you can create special file in YML format, that describes your products and put it on your site. Yandex market will download this file every day, parse products from it and show them here: http://market.yandex.ru . So visitors of Yandex Market can search offers from huge number of stores on one web site. If they want to buy your product, they will be redirected to page of that product on your site and can purchase it. You will pay to Yandex Market for each visitor of your store that comes from their web site.
Yandex market is the biggest service of such type in Russia. Most of stores in Russia are registered at Yandex Market and using it to get profit. Actually I don't understand how owners of Russian on-line stores driven by Drupal can live without integration with this service.
There one commercial solution(http://drupal-shop.ru/).Here you can buy whole Drupal e-commerce web site with support of exporting to Yandex Market(I don't try it, so I don't now is it working) but no free solution.
My module is aimed to fill this gap.

My module is a set of handlers and plugins for Views module. Also it plays well with Ubercart and CCK. So it is very flexible and customizable. Users can set up what they want to export to Yandex Market using standard Views interface. Full instructions are available in README.txt

I hope my module will be usefull and will help e-commerce store owners to make their stores more profitable.

Code is available here: http://www.hrbooks.ru/yandexmarket.tar.gz

Thank you for your attention and sorry for my awful English.

Comments

trashgenerator’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new13.38 KB
GerasimovSergey’s picture

Привет. Огромное спасибо за модуль, вы сохранили нереальное количество человеко-часов моего труда =)

mefisto75’s picture

Присодиняюсь к благодарностям!
Вопрос: когда модуль будет официально выложен? Безопасно ли его ставить на рабочий сайт?

trashgenerator’s picture

Can anybody review my module? Russian Drupal community waiting for official release.

Short description of module: It provides Views plugins and handlers, that generates special XML file. Users can configure this XML using this plugins and handlers.

Module has valid Drupal-styled code. And I believe it is secure.

-------
Релиз будет официально выложен, как только его кто нибудь из тех у кого есть соответствующая привилегия, заопрувит. Так что если у Вас есть такая возможность, можете это сделать=)
Во избежание недоразумений, обязательно проверяйте полученный YML файл. Пишите мне в личку о багах и пожеланиях, пока нету багтрекинга для него. Так же буду рад услышать просто о том, что Вы установили модуль и он полноценно работает. Понятно ли как использовать модуль? может что еще надо в readme написать?

trashgenerator’s picture

Issue tags: +Module review
avpaderno’s picture

Status: Needs review » Needs work

Hello, and thanks for applying for a CVS account.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

mefisto75’s picture

There are no existing solutions for Yandex Merchant/Market.
Features are similar to Google Base module http://drupal.org/project/googlebase
Russian community needs this module.

trashgenerator’s picture

Status: Needs work » Needs review
StatusFileSize
new34.31 KB
new159.22 KB

Thank you for reviewing my module.

More details about the features of the proposed module:
As mentioned above this module is something similar to googlebase module.
In attachement at picture 1 you can see part of UI of module, at picture 2 - YML, produced by this module.
User can define witch fields he wants to see in YML file. Module provides form with selectors, so even user, unfamiliar with YML format and XML in general, can get good results.

Comparison with the existing solutions:
One Drupal module called views_node_feed provides opportunity for creating XML files using Views. But that module provides only textfield, where programmer should enter php code,that generates XML. But it is too difficult for ordinary user to work with this module, because you should now structure of $views and $node variables, php language and structure of XML you want to create to do anything useful. Also this module calls node_load for every record in view. It is very general module and not good for specific tasks.
All that things are part of strategy of that module and not bugs or points for improvement.
In contrast, aim of my module is to provide solution for specific task, so it consist of UI intended only for one task(so every user can use it) and core intended only for one task(so it is not overloaded and not uses node_load or other resource-intensive functions). Also it provides Views fields aimed for one specific task, so providing such fields in views_node_feed will be illogical.

trashgenerator’s picture

hey, maybe I'm doing something wrong?
What information should I provide else?

volocuga’s picture

kiamlaluno: This module is very needed. The Yandex search engine currently #1 for people living in Russia,Ukraine and other countries of exUSSR. It even more important than Google. Please provide CSV access for @trashgenerator

Thanks

andypost’s picture

+1 to this useful module and author

EDIT: glad to join as co-maintainer

dzah’s picture

A really needed module indeed!

Being present on Yandex.Market is absolutely necessary for any store selling to customers in Russia and the FSU states.
There are almost no alternatives to that.
The YML (Yandex Market Language) is an XML - based standard for exporting product catalog to Yandex database.
Currently, there are no other modules that generate the YML file.

I request that it is a CVS access is granted to trashgenerator and that the
module is brought to release as soon as possible.

Alex

trashgenerator’s picture

StatusFileSize
new13.58 KB

New version of module is available.
-added closing tag
-now encoding of output file can be specified in View Style settings
-only not empty categories are shown now
-some code refactoring done

version is sponsored by volocuga

andypost’s picture

Status: Needs review » Reviewed & tested by the community

There's no duplicates at all.

avpaderno’s picture

Status: Reviewed & tested by the community » Needs review

Before the status is changed to reviewed & tested, there should be at least one review of the code.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

@kiamlaluno Code review I've done in #11 and version in #13 a bit factored to be cleaner. A bit of code-styling could be done in cvs

avpaderno’s picture

Status: Reviewed & tested by the community » Needs review

There isn't any explicit code review in comment #11.

botanik’s picture

Есть маленькое предложение .. в связи с тем, что Яндекс проверяет живость магазинов, нужно выставлять наличие/отсутствие товаров что бы не вылететь из маркета .. удобно если можно использовать CCK чекбокс (есть/нет) / радио (есть, нет, под заказ) для управления товарами на складах. Я конечно написал модуль, который делает тоже самое, но лучше включить такую возможность по-дефолту прям в модуль.

trashgenerator’s picture

botanik, никакого дополнительного модуля для этого писать не нужно. достаточно создать этот CCK чекбокс(например текстовое поле с вариантами выбора "true" и "false"). Потом добавить во view это поле. Потом в настройках view стиля указать это поле для "available ()"

avpaderno’s picture

Please write in English; not all users know Russian.

EllECTRONC’s picture

Useful module.

kiamlaluno, use http://translate.google.com/?hl=ru&tab=wT
They are speak about module features.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

@kiamlaluno Module has very simple code, all staff is views related. As I said before I have done review writing #11

I found no problems with security, user input allowed only in views configuration and all other output is done through views
Code mostly conform code-styling, except a few tabs...
Code is well-documented.

@trashgenerator Take care visit http://drupal.org/coding-standards and http://drupal.org/project/coder

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dzah’s picture

Using (the first version) of this module on a production site for more than a month now.
Never had any problems.
Should be promoted to release definitely.

trashgenerator’s picture

Thank you all for testing, reviewing and approving.
Module is now available at http://drupal.org/project/yandexmarket

If you already use this module, I think it is better to delete all views using it, uninstall it, delete it from disk and then install official release. Don't forget to back up.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes