Closed (won't fix)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Jan 2010 at 09:06 UTC
Updated:
27 Nov 2018 at 14:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
duckzland commentedComment #2
avpadernoRemember to change status, when you upload new code.
Why didn't you open a feature report for the other module?
Comment #3
duckzland commentedI wasnt sure which status should I set.
Do you mean I should open a feature report to ubercart project?.
Comment #4
avpadernoAs the module adds a block to Drupal showing the content obtained from Ubercart, I think the module doesn't make sense as stand alone project.
Comment #5
duckzland commentedWell the module adds 2 blocks and 2 pages to drupal, but who am I to argue if you think it doesn't make any sense to be a stand alone project.
Cheers
duckz
Comment #6
avpadernoI am not saying that it should not be added to Drupal.org CVS. We tend to give more space to cooperation, and IMO a module that adds a functionality to an existing project should be first proposed as feature request.
Comment #7
duckzland commentedahh I see sorry If I offended you, well I will try to add this module to the ubercart project and see if they are willing to add this as a feature or suggest me to add this as separated drupal module.
Anyway I have another module, its a testimonial recording module, currently it only display the testimonial in block with jquery but I am planning to add a page that will display the whole testimonial. Will this kind of module eligible in the drupal.org? I will upload them if you think there are no one developing this kind of module.
thanks
duckz
Comment #8
avpadernoI didn't get offended; I simply explained better what I reported in my previous comment.
Comment #9
duckzland commentedkiamlaluno
seems that ubercart doens't want any feature to be added to the core, so is it possible for me to have this module listed in drupal.org?
Comment #10
avpadernoMay you point out to any comments where it is stated ubercart doesn't accept any feature request?
Comment #11
duckzland commentedwell I send message like 1 week ago to ryan requesting adding feature to it and he didn't reply to me at all
Comment #12
avpadernoThat doesn't mean that feature requests are not accepted.
If you sent an email to the current maintainer, then the absence of reply could just mean that you have chosen the wrong media to ask for them (you should open a feature request in the project queue; that is the reason I asked for a link to a comment where it's clearly stated feature requests are not accepted).
Comment #13
duckzland commentedok I'll open a feature request in ubercart project page
Comment #14
duckzland commentedOpen the feature request for 6 days with no answer, can this be count as they don't want this in core?
Comment #15
tr commented1) Lack of response isn't a no, especially in the Ubercart queue where even important patches can languish for months.
2) However, based on my detailed knowledge of Ubercart acquired as a major contributor to the project for more than 2 years, I can tell you that there's absolutely no way this will be included in core. In fact, similar features were taken *out* of core and put into the uc_marketing contribution over a year ago.
3) That does not mean I think the module should be approved. In fact, the stated functionality in #1 duplicates that provided by other Ubercart contributed modules, specifically uc_marketing and uc_best_seller, and perhaps one or two others (ubercart.org has been down, so I can't research this completely). While there may be some minor differences (I'm not sure uc_best_seller provides a block, for instance), these seem to be more on the level of feature enhancements to existing contributions, and *not* appropriate as a stand-alone module.
As far as I can tell, you're just querying the {uc_best_sellers} table for your information anyway - you don't define your own tables or do your own determination of what is "popular". It really seems like all you've done is add some features to the existing uc_best_sellers module, in which case you should submit patches/feature requests to that module's issue queue.
Thus, I'm against hosting this module on drupal.org.
Comment #16
duckzland commentedAllright thanks for the comment and review.
Comment #17
avpadernoComment #18
avpaderno