CVS edit link for duckzland

I have created a module for ubercart, called uc_popular, the module will show a block of most popular products by node view count, a page for displaying the most popular product, a block to switch the page display from grid view to list view and a page to display the best seller of product.

depended on ubercart and uc_best_seller

CommentFileSizeAuthor
#1 uc_popular.zip14.45 KBduckzland

Comments

duckzland’s picture

StatusFileSize
new14.45 KB
avpaderno’s picture

Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Module review

Remember to change status, when you upload new code.

Why didn't you open a feature report for the other module?

duckzland’s picture

I wasnt sure which status should I set.

Do you mean I should open a feature report to ubercart project?.

avpaderno’s picture

As the module adds a block to Drupal showing the content obtained from Ubercart, I think the module doesn't make sense as stand alone project.

duckzland’s picture

Well the module adds 2 blocks and 2 pages to drupal, but who am I to argue if you think it doesn't make any sense to be a stand alone project.

Cheers

duckz

avpaderno’s picture

I am not saying that it should not be added to Drupal.org CVS. We tend to give more space to cooperation, and IMO a module that adds a functionality to an existing project should be first proposed as feature request.

duckzland’s picture

ahh I see sorry If I offended you, well I will try to add this module to the ubercart project and see if they are willing to add this as a feature or suggest me to add this as separated drupal module.

Anyway I have another module, its a testimonial recording module, currently it only display the testimonial in block with jquery but I am planning to add a page that will display the whole testimonial. Will this kind of module eligible in the drupal.org? I will upload them if you think there are no one developing this kind of module.

thanks

duckz

avpaderno’s picture

I didn't get offended; I simply explained better what I reported in my previous comment.

duckzland’s picture

kiamlaluno

seems that ubercart doens't want any feature to be added to the core, so is it possible for me to have this module listed in drupal.org?

avpaderno’s picture

May you point out to any comments where it is stated ubercart doesn't accept any feature request?

duckzland’s picture

well I send message like 1 week ago to ryan requesting adding feature to it and he didn't reply to me at all

avpaderno’s picture

That doesn't mean that feature requests are not accepted.
If you sent an email to the current maintainer, then the absence of reply could just mean that you have chosen the wrong media to ask for them (you should open a feature request in the project queue; that is the reason I asked for a link to a comment where it's clearly stated feature requests are not accepted).

duckzland’s picture

ok I'll open a feature request in ubercart project page

duckzland’s picture

Open the feature request for 6 days with no answer, can this be count as they don't want this in core?

tr’s picture

1) Lack of response isn't a no, especially in the Ubercart queue where even important patches can languish for months.

2) However, based on my detailed knowledge of Ubercart acquired as a major contributor to the project for more than 2 years, I can tell you that there's absolutely no way this will be included in core. In fact, similar features were taken *out* of core and put into the uc_marketing contribution over a year ago.

3) That does not mean I think the module should be approved. In fact, the stated functionality in #1 duplicates that provided by other Ubercart contributed modules, specifically uc_marketing and uc_best_seller, and perhaps one or two others (ubercart.org has been down, so I can't research this completely). While there may be some minor differences (I'm not sure uc_best_seller provides a block, for instance), these seem to be more on the level of feature enhancements to existing contributions, and *not* appropriate as a stand-alone module.

As far as I can tell, you're just querying the {uc_best_sellers} table for your information anyway - you don't define your own tables or do your own determination of what is "popular". It really seems like all you've done is add some features to the existing uc_best_sellers module, in which case you should submit patches/feature requests to that module's issue queue.

Thus, I'm against hosting this module on drupal.org.

duckzland’s picture

Status: Needs review » Closed (fixed)

Allright thanks for the comment and review.

avpaderno’s picture

Status: Closed (fixed) » Closed (won't fix)
avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes