CVS edit link for kilogauss

I have written a Drupal module making it very easy to integrate the FoxyCart (www.foxycart.com) e-commerce system with Drupal. I have found no other Drupal integration for FoxyCart.

This module provides a simple page of administration settings. Once configured, the required foxycart.com js and css files are included. There are also two theme-able cart status blocks that can be enabled. The foxycart module provides single sign on integration as well so that users can authenticate with foxycart.com with their drupal credentials. Other features include datafeed logging and account synchronization.

I have a very, very basic live example site running the module here: http://foxycart.ydbs.net. This will be enhanced as the module continues to improve.

Also, to provide full disclosure, I am part of the foxycart.com affiliate program. Some of the links to foxcyart.com in this module contain my affiliate id. So part of the motivation for this is to provide referrals for FoxyCart sign-ups. It is free for anyone to sign up and try, so I think by providing an easy way for people to try FoxyCart with Drupal will create a compelling case for both products. I personally know one of the owners, but am in no other way associated with the company. I have found the product and the company to be very done with fantastic customer service.

CommentFileSizeAuthor
#8 foxycart.zip10.65 KBkilogauss
#5 foxycart.zip10.27 KBkilogauss
#1 foxycart.zip11.01 KBkilogauss
#3 foxycart.zip10.2 KBkilogauss

Comments

kilogauss’s picture

Issue tags: -Module review
StatusFileSize
new11.01 KB

Please disregard the file in this comment. See attachment in comment #3

avpaderno’s picture

Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Module review
kilogauss’s picture

StatusFileSize
new10.2 KB

I needed to fix a small bug and make update for coding standards. Please disregard the zip in comment #1.

dave reid’s picture

Status: Needs review » Needs work
Issue tags: +Module review

I am part of the foxycart.com affiliate program. Some of the links to foxcyart.com in this module contain my affiliate id.

Please make this opt-in if it's not already.

I would like to try this module out without having to signup to download FoxyCart. Is that possible?

kilogauss’s picture

StatusFileSize
new10.27 KB

Hi Dave,

There is only one user-facing link with the affiliate ID, and I made that optional (off by default). You can now see this in the attached zip.

Unfortunately, the module really won't do anything until you supply your foxycart domain name. So to really try it out, you would need to sign up for a free account. However, I could give you access to view the foxycart settings on my test site if you would like. I will send you a PM with an account you can try.

avpaderno’s picture

Status: Needs work » Needs review

@kilogauss: I take your affiliate ID is not used from the module anymore.
I am changing the status as per previous comment. Remember to change status when you upload new code.

avpaderno’s picture

Status: Needs review » Needs work

The module doesn't have the installation file, which should contain at least the implementation of hook_uninstall().

kilogauss’s picture

Status: Needs work » Needs review
StatusFileSize
new10.65 KB

Added install file and uninstall hook to clean up. Thanks.

avpaderno’s picture

Status: Needs review » Fixed
version = "6.x-1.0"
project = "foxycart"

Those lines needs to be removed, as they are added from the packaging script, and having multiple copies of those lines confuses the update script.

  $items['admin/foxycart'] = array(
  	'title' => t('FoxyCart'),
  	'page callback' => 'drupal_get_form', 
  	'access arguments' => array('access administration pages'),
  	'page arguments' => array('foxycart_admin_settings'),
  	'file' => 'foxycart.module');

Menu titles, and descriptions should not be passed to t() as that is already done by Drupal core code.
Replace any character tab with two spaces, that is the indentation character suggested by coding standards.

    switch ($op)
    {
      case 'submit':

The curly bracket needs to be inline with the control operator (switch, while, if, etc).

  header('Location: ' . $full_redirect);

The code should use drupal_set_header().

  $logolink = fclink('<img id="fc_admin_logo" src="' . $base_root. '/' . $path . '/powered-by-foxycart-108x46.png" alt="Powered by FoxyCart Ecommerce" />');

There is a theme function for image tags.

  	'#description' => '<p>' . $logolink . t('Here you can configure all of your'). ' ' .fclink('FoxyCart') . ' ' .  
  t('integration settings.') .'<br/>' . t('If you do not yet have a FoxyCart account,') . ' ' . fclink('Click Here to Sign up.') . ' ' . t('It\'s easy and free to try') .'.</p>' );

Use t()-placeholders instead of concatenating string; in that way who translates the sentence has a context. The sentence should be written in sentence case (This is written in sentence case), and there should not be any quote escaping (use a different string delimiter, if that character is already used inside the string).

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.