Closed (won't fix)
Project:
Drupal.org CVS applications
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Dec 2009 at 08:21 UTC
Updated:
28 Dec 2009 at 15:33 UTC
Jump to comment: Most recent file
Comments
Comment #1
avpadernoAcquia Marina 6.x-2 already have the support for fluid layout.
If what you propose doesn't already exist in Acquia Marina, why didn't you create a feature request for the theme?
Comment #2
Observer8 commentedAt resolution 1920x1080 original Acquia Marina 1.9 looks like a hals-screen only. In style.css it defined at 960px fixed width and don't grow up, so its fixed theme, not fluid. :(
I have already make my own twiks and make it as new module for future scalability and compatibility with future Acquia Marina versions.
Why should I request for the new feture for the theme, if it has already created by me? I only want to share it with other people, but don't now how. :) That's why I think publishing it as new module will be a good idea.
Сertainly the same changes could be implemented to the original theme and it will looks good at 1024px screen width AND any other wider resolutions, but how can I do that? I'm not the author of Acquia Marina Theme and can not make any changes to it...
I put in fluid-style.css with all necessary changes, but I'm not sure that such changes in existing code doesn't destroy anythyng. :)
What should I do about it? I'l be very appreciated for any advice about it.
P.S. Acquia Marina 2.0 is in alpha stage so I don't know what does it have or not, sorry.
Comment #3
avpadernoTell me if I understand well; you created a fork of an existing theme, and you are using it for a CVS application.
In the page for applying to CVS account is clearly stated that applications where the proposed code is the duplicate of an existing project are rejected.
I could, differently, create a fork for Views, change some lines, and apply for a CVS account.
Comment #4
avpadernoThe attached archive doesn't contain a theme, nor a module. We only accept a complete theme, or a complete module.
Comment #5
Observer8 commentedI have already give the link to the complete source code when I was asking a CVS account, cause request-form does not allow attach files, so I gave a link. style.css was given again only for information.
There is complete theme as complete module.
Example: theme ad_novus consists of two modules, fixed and fluid theme, one into another. I just made fluid version of Acquia Marine and want to share it with other people, cause at now it's only fixed.
Comment #6
Observer8 commentedAbove I posted complete theme module
Comment #7
avpadernoAs reported in the Apply for contributions CVS access:
As you modified an existing theme just to add a feature, this applies to you.
There are many reasons we don't accept a CVS application, in these cases. if we would, then many users would get a CVS account by proposing a module that simply modifies the settings page of another module.
The purpose of a CVS application is also to verify if the applicant understood how to write a Drupal module / theme; in this case, this is not possible.
Comment #8
Observer8 commentedOK, now I understood process and reasons. Thanks for explanation. :)
I have already make issue with my information and now I could be sure that this is enough and I shouldn't do anything else with this. Thanks again. ;)