CVS edit link for alli.price

After six months of developing with Drupal and familiarising myself with the community, cvs, svn and patching I feel I can contribute to a few third party modules.

I also wish to release a module to help facilitate implementation of HTML5, modern browsers do fine with the new standard, IE lte 8 and Firefox 2/Camino need a little help. My module implements fixes.

CommentFileSizeAuthor
#5 html5.zip6.52 KBheylookalive
#1 html5.zip6.5 KBheylookalive

Comments

heylookalive’s picture

heylookalive commented
Issue tags: +html5
StatusFileSize
new html5.zip6.5 KB

Please find attached my proposed module's code, sorry for the delay with my previous submission (noticed a couple things to clear up). I have ran the module through coder, and it works in fixing the issues outlined above, also with a configurable entities list for IE.

Thanks!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: -html5 +Module review

Remember to change the status, when you upload new code.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The previous application was #580792: alli.price [alliprice].

ajk’s picture

ajk commented
Assigned: Unassigned » ajk
Status: Needs review » Needs work 
  // set fix status variable
  variable_set('html5_gecko_fix_active', $gecko_fix_active);

Are you using a Drupal variable via the database to tell one part of your system the status of another?

heylookalive’s picture

heylookalive commented
Status: Needs work » Needs review
StatusFileSize
new html5.zip6.52 KB

I was but in retrospect, this isn't necessary so have now changed this to a global variable.

Thanks!

ajk’s picture

ajk commented
Status: Needs review » Fixed
heylookalive’s picture

heylookalive commented

Thanks! :)

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.