Gomez_in_the_South [gomezinthesouth]

      if(time() - $last_update >0 ) {       
      $q = " SELECT count(*) as num FROM {watchdog}  WHERE";
      $where = "";
      $message = "Entries with ";
      if(strlen($filter[SENTINEL_F_TYPE])>0) {
        $where = " type IN ( '".$filter[SENTINEL_F_TYPE]."') AND ";
        $message .= " <br> type : " . $filter[SENTINEL_F_TYPE] ;
      }
      if(strlen($filter[SENTINEL_F_SEVERITY])>0){
        $where .=" severity IN ( ".$filter[SENTINEL_F_SEVERITY].") AND ";
        $sev_html = $filter[SENTINEL_F_SEVERITY];
         foreach ($severity_words as $key => $value) {
        $sev_html = str_replace($key, $value, $sev_html);
        }
         $message .= "<br> severity : ".$sev_html;  
      }
      if(strlen($filter[SENTINEL_F_USER])>0){
        $where .=" uid IN ( ".$filter[SENTINEL_F_USER].") AND ";
         $message .= "<br> user(s) : ".$filter[SENTINEL_F_USER];  
      }
      if(strlen($filter[SENTINEL_F_KEYWORD])>0){
        $where .="  message LIKE '%".$filter[SENTINEL_F_KEYWORD]."%' OR variables LIKE '%".$filter[SENTINEL_F_KEYWORD]."%' AND ";
         $message .= "<br> Keyword(s) : ".$filter[SENTINEL_F_KEYWORD];  
      }
      if(strlen($filter[SENTINEL_F_RANGE])>2){
       
        $where .=" timestamp  BETWEEN ".$filter[SENTINEL_F_RANGE];         
         $range_arr = explode("and",$filter[SENTINEL_F_RANGE]);

The message string is built by concatenating strings, and it is not translatable, in that way.
The SQL query is built concatenating strings, and some of the dynamic strings are not appropriately filtered; db_query() supports placeholders.

See the Drupal coding standards to understand how a module code should be written.

1. core = 6.x
   dependencies[] = dblog
   version = "6.x"
   core = "6.x"
   

   The version line should be removed, and the core line appears twice.

2.   $items['admin/reports/sentinel/view_message'] = array(
       'title' => 'Messages',     
       'page callback' => 'sentinel_show_message', 
       'page arguments' => array(4), 
       'access arguments' => array('access site reports'),     
       'file' => 'sentinel.admin.inc', 
       'type' => MENU_CALLBACK, 
     );
   

   If you need to pass the number 4 as argument, you need to pass it as string; differently it would probably changed from the menu code handler present in Drupal core code.

3.     'title' => 'General settings', 
       'description' => t("General settings."), 
   

   Those strings must be passed not translated; Drupal core code will get the translation itself.

4. I have already reported about the coding standards; the code does not complain with them.

I forgot to change the status.

The e-mailing feature duplicates the Logging and alerts modules. Maybe the other features proposed here could be merged into the existing module package?

I agree with Dave.

I am adding the review tags.

There have not been replies from the OP in the past 7 days. I am marking this report as won't fix.

You need to re-apply for the CVSs account, as it has been already declined; changing the status of this report doesn't change the status of the application.