CVS edit link for miccil

I want to post new project. My new module name is mimemailengine. This is a new implementation for a mimemail engine that contains a fix for mimemail Return-Path issue on Unix systems (postfix and sendmail mail servers)
CommentFileSizeAuthor
#5 mimemailengine-6.x-1.1.zip7.26 KBmiccil
#1 mimemailengine.zip7.27 KBmiccil

Comments

miccil’s picture

miccil commented
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +MIME mail, +mimemail
StatusFileSize
new mimemailengine.zip7.27 KB

This is my new module's code

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: -MIME mail, -mimemail +Module review

Hello, and thank you for applying for a CVS account.

As per requirements, the motivation message should include more than two sentences to describe the module features, and a comparison with the existing solutions.

miccil’s picture

miccil commented
Status: Needs work » Needs review

Hi kiamlaluno,
sorry for the quick description. I post a more detailed one.
--
Unix mail servers, such as postfix and sendmail, appear to over-write any 'Return-Path' headers sent by the PHP mail() function, using an email addess based on the account name Apache runs as on the server, e.g. apache@example.com. In this case bounce mails are returned to apache@example.com.

The solution is to use fifth parameter of mail fiunction, using -f or -r options with real Return-Path address.
This approach is used by Retrun-Path module - http://drupal.org/project/returnpath, overwriting drupal_mail function, and works like a charm.

But Mime Mail module doesn't use drupal_mail function for sending mails. Mime Mail uses its own mail engine or a mail engine provided by another module. This module implements al alternative mail engine for Mime Mail that add -f and -r options to fifth parameter of php mail function, solving the issue also with Mime Mail.

ringomassa’s picture

ringomassa commented

Hi miccil,

Just the module i was looking for. However, it didn't work for me until i changed:

mimemail_rfc_headers($message['headers']),
"-r". $return_path." -f". $return_path)

to

mimemail_rfc_headers($message['headers']),
" -f". $return_path)

miccil’s picture

miccil commented
Component: Miscellaneous » miscellaneous
StatusFileSize
new mimemailengine-6.x-1.1.zip7.26 KB

Hi ringomassa,
thanks for you reply. I update the code and removed -r flags.
Modified version in attached

zzolo’s picture

zzolo commented
Status: Needs review » Postponed

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Postponed » Closed (won't fix)

As per previous comment, I am setting this issue as Won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: miscellaneous » new project application