On line 69, this module is overwriting any other possible #validate hooks that a module might want to add. Instead, it should look like this:

    $form['#validate'][] = 'custom_username_validation_username_validate';

Comments

Schneck’s picture

Schneck commented
Assigned: Unassigned » Schneck
Status: Active » Fixed

Thanks for the hint, should be fixed and available for download soon. Since CVS totally sucks, I hope I tagged it correctly and the bundle script does handle it.

Schneck’s picture

Schneck commented
Status: Fixed » Closed (fixed)
sphism’s picture

sphism commented
Priority: Normal » Critical
Status: Closed (fixed) » Needs work

Weird, this doesn't actually fix the problem.

using drupal for firebug i see that you can only ever get 1 validate function in the list, it's weird. something is overriding the second one????

I've marked this as critical since it overwrites the drupal user validate function users can sign up with same username and or email address as someone else. But then drupal falls over when it tries to actually add them in and so it looks like they have registered but they haven't.

matt

Schneck’s picture

Schneck commented
Status: Needs work » Needs review

Hi there,

you're totally right, and i'm terribly sorry that this relict from ancient times called "cvs" costs me so much time... Please download the 1.2, I committed the same patch again, downloaded the result and checked the source. Should be fine now.
Please give me feedback whether it's running as expected now.

Schneck’s picture

Schneck commented
Version: 6.x-1.0 » 6.x-1.2
Schneck’s picture

Schneck commented
Status: Needs review » Closed (fixed)