As this is already easily doable now with the content_profile, content_profile_registration, and autoassignrole modules can you please clarify how this module differs from that solution on the project page?

Comments

drupaledmonk’s picture

May be you can add a readme file to the module for the users. I hope this module makes my work easier than autoassign role+content profile.

cmcintosh’s picture

What this module allows you to do is have several such registration forms customized to the needs of different entry points. This is something I was unable to do with Content Profile and the Content_Profile_Registration, which would only allow you to modify a single registration form. Through this module you could have a form for normal users, partners, different types of partners, etc. It does not need Auto Assign role as it will assign the users to the role according to the registration form they fill out.

WorldFallz’s picture

Ok, now I'm totally confused, lol. With content_profile you can have as many different content types for profiles as you like and enable them for different roles via permissions.

drupaledmonk’s picture

This is something I was unable to do with Content Profile and the Content_Profile_Registration, which would only allow you to modify a single registration form.

content_profile creates different registration pages for different roles when used with auto-assign role based on path. I don't get what you meant in #2.

WorldFallz’s picture

Exactly -- i'm not getting it either which is why there needs to be a statement on the project explaining what this module does that content_profile + autoassignrole can't do.

cmcintosh’s picture

Status: Active » Needs work

If either of you would like to try the module out and give me feedback as to how the description should read im more than happy to get some feedback. I am more of a developer and less of a author.

WorldFallz’s picture

i'm more than happy to contribute documentation and help maintainers when i can, but part of being a maintainer is describing what your module does. If you were applying for a cvs account for this module you would need to describe how what it does is different from existing solutions before you were even approved. Your application was for a completely different module-- bad practice in and of itself. Ive submitted an issue for this separately (http://drupal.org/node/893242).

We're not asking you document your module-- we're asking you to explain what it does. Apparently you've already tried the other method and decided it doesn't work. Are you really saying you can't describe why you wrote this module? I already maintain a couple of modules and spend a lot of time and effort helping in the forums as well-- i dont really have time to do this part of your job for you as well.

it really is your responsibility to describe what your module does in enough detail for inexperienced users to be able to make a decision about which modules to use.

Anonymous’s picture

Maybe a screencast where the module is run through it's paces? This might make it easier for people to write documentation, if docs are still needed after a screencast.

avpaderno’s picture

What it's being asked is to describe the module more, and make clear what the difference between the module and the existing one is.
It would be also better to link the other(s) existing module(s) using a sentence like If you are interested in similar modules, see ….

avpaderno’s picture

Status: Needs work » Active
avpaderno’s picture

Title: clarification » What is the difference between this module, and the existing ones?
cmcintosh’s picture

Here is a link to the screencast: http://www.youtube.com/watch?v=XzeTGGUPpzY

avpaderno’s picture

@cmcintosh: It's the project page that needs to be changed.

cmcintosh’s picture

For anyone wondering This module is only to get a quick solution to having different registration forms based on path, ideally what im doing here can be used and rerolled into autoassignrole. I looked at the module and seems very sound for everything else except this piece of functionality. Its meant as a bandaide solution and I am not trying to diminish any other module whatsoever

cyberswat’s picture

@cmcintosh The first I've heard of this module was you advertising it in the autoassignrole issue queues just now. I've been seeking a co-maintainer and help with that module for some time. You've made no effort to contact, submit patches, or ask questions but you have duplicated the functionality of the autoassign role module. Not only that but you are doing it to make money ... $7,500 to finish your work? http://customreg.chrismcintoshdesigns.com/ ... excellent form, nice to meet you Mr. McIntosh.

cmcintosh’s picture

Actually i dont expect any money for what i am doing, i put the chipin widget on anything that i share on the web.

cyberswat’s picture

@cmcintosh Let me take a step back and approach this from a different angle. As I've stated, I have been looking for a co-maintainer of autoassignrole for some time. I am actively seeking legitimate contributors to help with the module. I would love nothing more than to work with active people that are driven to help improve a workflow that has positively benefited a good number of Drupal sites.

That being said, autoassignrole has active issues that need attention. The content profile integration you are focusing on was written by the maintainer of the content profile module and is an aspect of autoassignrole I have never used. If you can help provide working use cases and solutions to issues autoassignrole is having I would love to implement them into the module. If you are active, can submit quality code or illustrate that your going to put in the effort to learn to submit quality code then I would happily list you as a co-maintainer for the module.

I'm incredibly responsive on irc, in my issue queues when I'm being addressed with solid patches, and attempt to be as positive in the Drupal community as I can. If there is anything I can do to help, within reason, I will do so. Hopefully some of this might motiviate you to work with me and others to continue to make Drupal the best it can be. I appreciate your ambition and do wish you the best of luck either way.

cmcintosh’s picture

@cyberswat would love to do some help with the auto assign role. i have one live site and a second launching tomorrow. The biggest difference I have noticed in the approach for the auto assign role versus the one i took was I had a single role, path, and content profile associated. Where it looks like your trying to be able to assign content types to the built paths. Its a bit late right now and i may not be typing or thinking clearly enough to go through all of my thoughts I had. ill take another look tomorrow after work and see if i can figure out exactly why options are not being saved.

I dont know if this is an option, but was there a reason that you(or who ever wrote that bit of code) decided not to create a simple table to track the paths, node types, and associated role? it seems that it tries to reset the value of the option field to the one selected(trimming off the null values), then passing it on to content_profiles submit function. I looked at that function a bit, but again did not see anything that stood out to me as being able to store those values anywhere. let me know if i missed something there.

My config page submit function looks like this, maybe we can take this and optimize it for what your doing:
function custom_registration_admin_form_submit(&$form, &$form_state)
{
$system_roles = user_roles();
foreach($system_roles as $role)
{ // THIS COULD GET SLOW IF WE HAVE LOTS OF ROLES
if( isset($form_state['values']['path_'.str_replace(' ', '_', $role)]) ){

$custom_form = db_result(db_query('SELECT COUNT(*) FROM {custom_registration} WHERE role = "%s"', $role) );
if($custom_form == 0)
{

//$custom_registration = new stdClass();
$path = $form_state['values']['path_'.str_replace(' ', '_', $role)];
$type = $form_state['values']['type_'.str_replace(' ', '_', $role)];
variable_set('path_'.str_replace(' ', '_', $role), $path);
variable_set('type_'.str_replace(' ', '_', $role), $type);
$data = array('path' => $path, 'type' => $type, 'role' => $role, );
drupal_write_record('custom_registration', $data);
} else {
// Update existing form
$path = $form_state['values']['path_'.str_replace(' ', '_', $role)];
$type = $form_state['values']['type_'.str_replace(' ', '_', $role)];
variable_set('path_'.str_replace(' ', '_', $role), $path);
variable_set('type_'.str_replace(' ', '_', $role), $type);
db_query("Update {custom_registration} SET path = '%s', type = '%s' WHERE role = '%s'", $path, $type, $role);
}
}
}
}

Then i have a hook_menu function that runs a custom sql query and generates the paths. i dont use any menu_alter, but your method in auto assign role is probably better. I also took a function from content_profile_registration that made it possible to load the form on the user registration page.

... Ill be back on some more to finish my thoughts. I have a few meetings early from 8am - 1pm CST, but after should be good to get on IRC for talk.

WorldFallz’s picture

wow lots of time and effort and still no answer to what I consider a very simple question.

This module is only to get a quick solution to having different registration forms based on path.

Content_profile + autoassignrole do this now, and have for some time, so I still don't know what your module does that content_profile + autoassignrole doesn't.

As someone who spends a lot of hours providing assistance in the forums I really don't relish the idea of wasting valuable time having to explain the difference between this module and content_profile + autoassignrole ad infinitum.

Whether or not you decide to pursue collaborating with cyberswat (the best path forward for the drupal community imo), this project page needs to be updated as soon as possible. I'm even willing to do the update for you-- I just need to know, specifically, what the functional differences are between this module and content_profile + autoassignrole. And no, I'm sorry, but I don't have time to set up dev sites for both methods to suss that out for myself. As I said earlier, as the publisher of the duplicate module (one for which you did not receive cvs account approval), the onus is on you to provide that info to the user and development community.

cmcintosh’s picture

@WorldFallz I will solve the confusion and bring down the project. This functionality will be moved into Auto Assign Role, currently the Content Profile integration into the Paths part of Auto Assign Role does not work.

cyberswat’s picture

If any are interested we are focusing on collaboration in issue #899796: Evaluate Custom Registration integration

avpaderno’s picture

Are there updates on this report?

JohnForsythe’s picture

@cmcintosh Thanks for writing this module, it does exactly what I need.

I'm sorry to see you got badgered into taking it down by people who didn't understand it.

cyberswat’s picture

badgered? Really?

cmcintosh’s picture

its more of i have more important things to do with my time than deal with petty coders who cant share a feature space.

cyberswat’s picture

Actually we are looking for help and consolidation of effort ... petty? Nope. Badgering ... Nope. If the two of you don't get that then I am truly sorry and am in awe of you both.

cmcintosh’s picture

I dont care for you which is why i choose not to consolidate my effort. Thanks

cmcintosh’s picture

thought we were not supposed to be asking for donations? whats up cyberswat? http://kevinbridges.org/

Love the theme on the site btw, really cool

avpaderno’s picture

I don't see in which way what somebody does in his own site has anything to do with what is allowed on Drupal.org.

cyberswat’s picture

This is quickly becoming accusational. I pay $75 a year out of pocket to cover the costs of http://www.meetup.com/drupal-colorado/ and have since Mar 14, 2008. I think what you are referring to as the sponsorship block that allows the meetup.com sponsors to give the group money. We utilize those funds, when they are provided to help recuperate the costs for those of us that go out of way to provide beer, pizza, meeting spaces, etc for the 6 regular meetups we host in Colorado.

I appreciate that you enjoy the theme of a stock generic site that hasn't been touched in well over a year and will happily provide you with active projects I work on if your so interested ... but fail to understand how any of that is relevant to your accusation.

avpaderno’s picture

The project has been marked as abandoned, and this thread is becoming off-topic.

avpaderno’s picture

Status: Active » Closed (outdated)

I am closing this issue, since the project has been already marked abandoned.