https://www.drupal.org/docs/7/site-building-best-practices/best-practices
FILE: ...ites/all/modules/custom_breadcrumbs/custom_breadcrumbs.admin.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
404 | WARNING | All variables defined by your module must be
| | prefixed with your module's name to avoid name
| | collisions with others. Expected start with
| | "custom_breadcrumbs" but found
| | "custom_breadcrumb_home"
740 | WARNING | Unused variable $options.
766 | WARNING | Unused variable $names.
----------------------------------------------------------------------
FILE: ...l/sites/all/modules/custom_breadcrumbs/custom_breadcrumbs.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
360 | WARNING | Unused variable $title.
721 | WARNING | Unused variable $args.
722 | WARNING | Unused variable $cond.
725 | WARNING | Unused variable $p.
774 | WARNING | Unused variable $key.
829 | WARNING | Unused variable $mlid.
1184 | WARNING | Unused variable $key.
----------------------------------------------------------------------
FILE: ...om_breadcrumbs_identifiers/custom_breadcrumbs_identifiers.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
99 | WARNING | There must be no blank line following an inline
| | comment
200 | WARNING | All variables defined by your module must be
| | prefixed with your module's name to avoid name
| | collisions with others. Expected start with
| | "custom_breadcrumbs_identifiers" but found
| | "custom_breadcrumbs_none_span"
----------------------------------------------------------------------
FILE: ...rumbs/custom_breadcrumbs_panels/custom_breadcrumbs_panels.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------
116 | WARNING | Variable $handler is undefined.
120 | WARNING | Variable $handler is undefined.
126 | WARNING | Variable $contexts is undefined.
131 | WARNING | Variable $handler is undefined.
132 | WARNING | Variable $handler is undefined.
146 | WARNING | Variable $task is undefined.
146 | WARNING | Variable $task is undefined.
148 | WARNING | Variable $contexts is undefined.
158 | WARNING | Variable $task is undefined.
158 | WARNING | Variable $task is undefined.
201 | WARNING | All variables defined by your module must be
| | prefixed with your module's name to avoid name
| | collisions with others. Expected start with
| | "custom_breadcrumbs_panels" but found
| | "custom_breadcrumbs_taxonomy_panels"
----------------------------------------------------------------------
FILE: ...crumbs/custom_breadcrumbs_paths/custom_breadcrumbs_paths.install
----------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
14 | ERROR | Do not use t() or st() in installation phase hooks,
| | use $t = get_t() to retrieve the appropriate
| | localization function name
31 | WARNING | Unused variable $id.
32 | WARNING | Messages are user facing text and must run through
| | t() for translation
37 | ERROR | Do not use t() or st() in installation phase hooks,
| | use $t = get_t() to retrieve the appropriate
| | localization function name
40 | ERROR | Do not use t() or st() in installation phase hooks,
| | use $t = get_t() to retrieve the appropriate
| | localization function name
----------------------------------------------------------------------
FILE: ...dcrumbs/custom_breadcrumbs_paths/custom_breadcrumbs_paths.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------
137 | WARNING | Variable $max is undefined.
137 | WARNING | Variable $max is undefined.
137 | WARNING | Variable $max is undefined.
----------------------------------------------------------------------
FILE: ...umbs/custom_breadcrumbs_taxonomy/custom_breadcrumbs_taxonomy.inc
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
18 | WARNING | Unused variable $v_alias.
187 | WARNING | Variable $vid is undefined.
203 | WARNING | Variable $lweight is undefined.
203 | WARNING | Variable $lweight is undefined.
203 | WARNING | Variable $lweight is undefined.
----------------------------------------------------------------------
FILE: .../custom_breadcrumbs_taxonomy/custom_breadcrumbs_taxonomy.install
----------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
15 | WARNING | Messages are user facing text and must run through
| | t() for translation
25 | WARNING | Unused variable $id.
42 | ERROR | Do not use t() or st() in installation phase hooks,
| | use $t = get_t() to retrieve the appropriate
| | localization function name
54 | ERROR | Do not use t() or st() in installation phase hooks,
| | use $t = get_t() to retrieve the appropriate
| | localization function name
57 | ERROR | Do not use t() or st() in installation phase hooks,
| | use $t = get_t() to retrieve the appropriate
| | localization function name
60 | WARNING | Messages are user facing text and must run through
| | t() for translation
----------------------------------------------------------------------
FILE: ...s/custom_breadcrumbs_taxonomy/custom_breadcrumbs_taxonomy.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
198 | WARNING | Variable $max is undefined.
198 | WARNING | Variable $max is undefined.
198 | WARNING | Variable $max is undefined.
545 | WARNING | There must be no blank line following an inline
| | comment
----------------------------------------------------------------------
FILE: ...crumbs/custom_breadcrumbs_views/custom_breadcrumbs_views.install
----------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
13 | WARNING | Messages are user facing text and must run through
| | t() for translation
31 | WARNING | Unused variable $id.
32 | WARNING | Messages are user facing text and must run through
| | t() for translation
37 | ERROR | Do not use t() or st() in installation phase hooks,
| | use $t = get_t() to retrieve the appropriate
| | localization function name
40 | ERROR | Do not use t() or st() in installation phase hooks,
| | use $t = get_t() to retrieve the appropriate
| | localization function name
----------------------------------------------------------------------
FILE: ...dcrumbs/custom_breadcrumbs_views/custom_breadcrumbs_views.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------
97 | WARNING | Variable $max is undefined.
97 | WARNING | Variable $max is undefined.
97 | WARNING | Variable $max is undefined.
----------------------------------------------------------------------
Comments
Comment #2
renatog commentedPatch with fixes.
Comment #4
renatog commentedFixed.
Commited in dev branch.
Regards.
Comment #5
renatog commented