The uniform variable syntax has changed in php 7:

                          // old meaning            // new meaning
$foo->$bar['baz']       $foo->{$bar['baz']}       ($foo->$bar)['baz']

Might be good to update the code accordingly.

Similar issues:

CommentFileSizeAuthor
#7 custom_breadcrumbs-2794527-7.patch2.18 KBlamp5
#4 2794527-4-custom_breadcrumbs-php7-uniform_variable_syntax.patch1.86 KBsjerdo
custom_breadcrumbs-php7-uniform_variable_syntax.patch1.86 KBfengtan

Comments

fengtan created an issue. See original summary.

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Issue summary: View changes
fengtan’s picture

fengtan
Location Montreal, Canada
commented
Issue summary: View changes
sjerdo’s picture

sjerdo
Primary language Dutch
Location Haarlem
commented
StatusFileSize
new 2794527-4-custom_breadcrumbs-php7-uniform_variable_syntax.patch1.86 KB

Updated patch for 7.x-2.x branch.

Status: Needs review » Needs work

The last submitted patch, 4: 2794527-4-custom_breadcrumbs-php7-uniform_variable_syntax.patch, failed testing. View results

sjerdo’s picture

sjerdo
Primary language Dutch
Location Haarlem
commented
Status: Needs work » Reviewed & tested by the community

Seems like tests aren't set for 7.x-2.x-dev
Updating to RTBC, since the patches are equal.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
StatusFileSize
new custom_breadcrumbs-2794527-7.patch2.18 KB

Refactored all $vars

  • lamp5 committed 18fd16a on 7.x-2.x 
    Issue #2794527 by fengtan, sjerdo, lamp5: PHP 7 - uniform variable...
lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.