Hi,

There are some phpcs coding standard errors which are listed in the attachment. Please do check.

Thanks.

CommentFileSizeAuthor
#4 interdiff-2941607-3-4.txt0 bytesanisha.challa
#4 csv_importer-coding_standards-2941607-4-D8.patch4.71 KBanisha.challa
#3 coding_standards-2941607-3.patch3.29 KBsivaprasadc
#3 interdiff-2941607-2-3.txt1.39 KBsivaprasadc
#2 fixed_coding_standard_2941607-2.patch2.49 KBprafullsranjan
csv_importer_errors.txt9.08 KBanisha.challa

Comments

anisha.challa created an issue. See original summary.

prafullsranjan’s picture

prafullsranjan commented
Status: Active » Needs review
StatusFileSize
new fixed_coding_standard_2941607-2.patch2.49 KB

I'm adding a patch to fix coding standard. Hope it'll help.

sivaprasadc’s picture

sivaprasadc commented
StatusFileSize
new interdiff-2941607-2-3.txt1.39 KB
new coding_standards-2941607-3.patch3.29 KB

@prafullsranjan

Thanks for the patch. Still few warning are there. Please find the attached interdiff and patch files.

anisha.challa’s picture

anisha.challa commented
Assigned: anisha.challa » Unassigned
StatusFileSize
new csv_importer-coding_standards-2941607-4-D8.patch4.71 KB
new interdiff-2941607-3-4.txt0 bytes

I have made some changes to the patch "coding_standards-2941607-3.patch". Please review the attached patch.

  • lashabp committed 880ad47 on 8.x-1.x 
    Issue: #2941607 Fix coding standards
lashabp’s picture

lashabp commented

Pushed the fix in dev branch, thanks for the patches.

anisha.challa’s picture

anisha.challa commented
Status: Needs review » Fixed

Hi,
Could you please give a credit for the patch :)

lashabp’s picture

lashabp commented

I applied #4 patch this one fixed all the errors and warnings, thanks @anisha.challa

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.