Social media icons are not visible in the header region. I have attached a screenshot for ref.

CommentFileSizeAuthor
#12 before.png13.56 KBtanuja bohra
#12 after.png23 KBtanuja bohra
#11 interdiff_3193989_3_11.txt481 byteschandreshgiri gauswami
#11 3193989-11.patch1.23 KBchandreshgiri gauswami
#4 Screenshot_1.png7.03 KBnishat ahmad
#4 Untitled.png30.19 KBnishat ahmad
#3 socialmedia_icon_issue-3193989-03.patch1.23 KBlokeshsahu
#3 Screenshot 2021-01-21 at 7.51.01 PM.png43.19 KBlokeshsahu
Screenshot 2021-01-21 at 6.53.53 PM.png53.75 KBlokeshsahu

Issue fork creative_responsive_theme-3193989

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lokeshsahu created an issue. See original summary.

lokeshsahu’s picture

lokeshsahu commented
Assigned: Unassigned » lokeshsahu
lokeshsahu’s picture

lokeshsahu commented
Assigned: lokeshsahu » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot 2021-01-21 at 7.51.01 PM.png43.19 KB
new socialmedia_icon_issue-3193989-03.patch1.23 KB

I have added a patch for the above issue, please review and let me know if the patch is working.
I have added a screenshot for ref.

nishat ahmad’s picture

nishat ahmad commented
Status: Needs review » Needs work
StatusFileSize
new Untitled.png30.19 KB
new Screenshot_1.png7.03 KB

Hi,@lokeshsahu,
I have checked and getting these issues.

kunal_sahu made their first commit to this issue’s fork.

kunal_sahu opened merge request !2

kunal_sahu’s picture

kunal_sahu commented

@lokeshsahu Your patch has failed , because of a whitespace issue in your patch. However, I have created an MR. Please review and Merge this MR with some issues solved.

Thanks.

kunal_sahu’s picture

kunal_sahu commented
Status: Needs work » Needs review
tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Needs work

Verified the MR 2, on 9.5.8 and got this error:

error: patch failed: creative_responsive_theme.info.yml:3
error: creative_responsive_theme.info.yml: patch does not apply

chandreshgiri gauswami’s picture

chandreshgiri gauswami commented
Assigned: Unassigned » chandreshgiri gauswami
Status: Needs work » Active

I will work on it.

chandreshgiri gauswami’s picture

chandreshgiri gauswami commented
Assigned: chandreshgiri gauswami » Unassigned
Status: Active » Needs review
StatusFileSize
new 3193989-11.patch1.23 KB
new interdiff_3193989_3_11.txt481 bytes

Adding updated patch with interdiff file.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after.png23 KB
new before.png13.56 KB

Verified the "3193989-11.patch" on 9.5.8 and now the social icons are showing. Added screenshots for reference, RTBC++.