Copyright module turns 404's to 403's

We can confirm this bug also with Drupal 5.1. Removing the module resolved our issue as well.

It looked obvious to look into the menu hook for the solution.

It actually applies to the latest branch. If you commit the latest patch, beware it might need some more testing. I just saw it took away the 403-404 issue.

Oh, and I forgot to mention this: make sure you reset the menu! I use the devel module for this, but I guess it does it automatically when you browse to /admin/build/menu.

I have been thinking how the menu should be resetted. Browsing to admin/build/menu does not rebuild the menu structure (as it did with D4.x). For the moment, I only see one possiblity: write an update script for copyright.install which removes the invalid menu records from the menu table.

One question dhough: are these menu items used anyway? Otherwise, I would propose to remove that piece of code.

You can add a menu_rebuild() in an copyright_update_X() iirc. But I think that if you install a new version of the module (and running update.php), that is done anyway.

I was a bit puzzled about those menu entries too when I took over maintanance of the module. If we can remove them (eg not used), then I have no problem doing so.

I'll check it more carefully this evening.

I would propose to remove this menu snippet. I don't find how this is begin used. According to me, this is an artifact from old drupal versions (<4.7) and obsolete right now.

Ok, lets get some movement in this very unpleasant bug. I made a new patch based on the previous discussion on whether the piece of code that causes the troubles in the menu hook should remain in there. So, this new patch

1. removes the bad part from the menu hook
2. adds a new update function to the install file

Please test this if you can, and let us know whether it works. It deserves some attention since this is a major bug and driving people away from this nice module.

@Robrecht

I consider this issue as critical because anyone who will download the official release will encounter this issue. Is it possible to give this issue some love? The issue and patch are already to long in the pipeline.

any idea when this will get committed?

Fixed in 5.x-1.6. Thanks!