Problem/Motivation

File: src/ConvertBundles.php

ConvertBundles uses service locator calls like \Drupal::entityTypeManager(), \Drupal::entityQuery(), and \Drupal::service(). It is better to use dependency injection

Issue fork convert_bundles-3566147

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andrii momotov created an issue. See original summary.

andrii momotov’s picture

andrii momotov commented
Assigned: Unassigned » andrii momotov

I assigned the task myself because I plan to fix this issue and make a Merge Request.
Please do not work on this issue.

andrii momotov’s picture

andrii momotov commented
Assigned: andrii momotov » Unassigned
Status: Active » Closed (won't fix)

While working on the issue, I noticed that replacing \Drupal::… calls with dependency injection would require changing the getEntities() method from static to non-static. Since it may need to remain static, I decided not to change anything. Thanks.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.