Needs review
Project:
Context entity field
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
19 Jul 2013 at 13:36 UTC
Updated:
29 Jun 2017 at 12:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mavimo commentedThanks for patch.
There are some issue on coding standard and will be usefull to trim data (eg: "1, 2, 3" generate '1', ' 2', ' 3' and can genrate possibile error on comparison). Will be usefull to have a separate flag to indicate when a field is a multiple element or just a single element (eg, if a field is a testfield, text having ',' can genrate error).
Comment #2
mavimo commentedComment #3
rodlangh commentedThanks for the feedback, I'll try to fix the patch later this week.
Concerning the separate flag: Would it be usefull if an extra input field was provided where users could provide their delimiter? And when no option would be given, the function would only try to match a single value.
Comment #4
mavimo commented@Rodlangh: Yes, can be a solution. An accurate description will be required to make possible for user undestand the scope of field. Thanks for your work :)
Comment #5
rodlangh commentedDidn't make it last week, but here's a new version of the patch nonetheless.
Added delimiter field with description, trimmed the condition values while looping and hopefully paid more attention to the coding standards.
Comment #6
hass commentedAlso see #2057433: Empty do not work with file field
Comment #7
mavimo commentedComment #8
mavimo commented@Rodlangh: I added a first step of testsuite in project, can you re-roll your patch and add test?
Thanks!!
Comment #9
rodlangh commentedI'll look into it. Will take some time though, current deadlines got a bit more priority.
Comment #10
stephesk8s commentedPatch worked well for me. A big help. Thank you.
Comment #11
delacosta456 commentedhi
please is it possible to extend this patch for more option like :
Not equal to
Less than
greater than
etcc...
thanks