Currently the theme switcher reaction allows you to choose any theme for your context.

What I found was if I was using a few contexts to set my admin theme, then decided to change my admin theme I had to update these contexts to use the new theme as well.

This patch adds two options (default and admin) to the theme options and will switch the theme to either the default or admin theme specified in the site settings.

CommentFileSizeAuthor
#7 add_default_theme_options-3163677-6.patch1.81 KBloze
#4 add_default_theme_options-3163677-4.patch1.83 KBloze
#2 add_default_theme_options-3163677.patch1.76 KBloze

Comments

loze created an issue. See original summary.

loze’s picture

loze commented
Status: Active » Needs review
StatusFileSize
new add_default_theme_options-3163677.patch1.76 KB

Status: Needs review » Needs work

The last submitted patch, 2: add_default_theme_options-3163677.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

loze’s picture

loze commented
StatusFileSize
new add_default_theme_options-3163677-4.patch1.83 KB

Here is a reroll against the latest dev

loze’s picture

loze commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: add_default_theme_options-3163677-4.patch, failed testing. View results

loze’s picture

loze commented
Status: Needs work » Needs review
StatusFileSize
new add_default_theme_options-3163677-6.patch1.81 KB

There was a mistake in the last patch, this should be correct.

Status: Needs review » Needs work

The last submitted patch, 7: add_default_theme_options-3163677-6.patch, failed testing. View results

loze’s picture

loze commented
Status: Needs work » Needs review
deaom’s picture

deaom commented
Status: Needs review » Reviewed & tested by the community

If I understand this correctly the problem is, admin theme is set to seven and the reaction theme is also set to seven, then you go and change the admin theme to claro, but the reaction still stays on the seven, so you need to manually change it to now work on claro. But with this patch, user has an option to set it to Admin theme or Default theme, which then changes according to your theme setting changes.
If that is correct behaviour, then the last patch (#7) works, and can be committed. Will mark it as RTBC and then status can be changed if that is not intended use.

loze’s picture

loze commented

@DeaOm That is correct.

  • paulocs committed af8e141 on 8.x-4.x authored by loze 
    Issue #3163677 by loze, DeaOm: Add "Default Theme" and "Admin Theme" to...
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

Nice. Thanks!

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.