Closed (fixed)
Project:
Context
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Apr 2016 at 05:50 UTC
Updated:
10 Mar 2017 at 09:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
joco_sp commentedI confirm, that this is still an issue.
I tested it also with the dev release and on node page.
Comment #3
vanvemdenSame problem here. Here's the log error message it creates:
Location:
admin/structure/context/my_context_name/reaction/blocks/blocks/add/system_branding_block?_wrapper_format=drupal_modal&theme=mybootstrapMessage:
Symfony\Component\Routing\Exception\InvalidParameterException: Parameter "theme" for route "system.theme_settings_theme" must match "[^/]++" ("" given) to generate a corresponding URL. in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 199 of /var/www/html/drupal/core/lib/Drupal/Core/Routing/UrlGenerator.php).Comment #4
bobooon commentedI am using a Zen base theme and have reproduced the exact issue. I have created a patch which excludes site branding block configurations from being customized within the context interface. It does fix the error and I am able to add site branding block within contexts. It may not be the "perfect" solution so I'll let the maintainer take over from here. Thanks.
Comment #5
gcarless commentedPatch worked great for me -- thanks!
Comment #6
steveoliver commentedThis applies to an upcoming release.
Comment #7
titouilleIt's stange, but the patch from #4 work correctly when I add the site branding block on reaction, but problem re-appears when I try to edit the site branding block by clicking on the edit button.
In this case, $block_id is key like "143d5cee-abb2-422e-97c9-83a116829552".
If I retrieve the real id to compare, it work in both cases:
Edit: block is added to the list, but not displayed at all on the final page using context...
Comment #8
cslevy commentedThe patch from #4 adds the block in the context, but skips the configuration step. If you don't configure the Site branding block, then will not show up.
Also the edit won't work for the same reason, like @titouille mentioned.
The actual problem is that the form state doesn't contain the "block_theme". This is needed when the configuration form is built for the site branding. I created a patch to fix this issue. I added it generally, maybe will be necessary for other blocks as well
Comment #9
jonodunnett commentedPatch #8 worked for me. Thank you.
Comment #10
dawehner#8 fixed the issue for me. This looks also like the right bugfix
Comment #11
hypertext200#8 fixed the issue
Comment #12
tatan313 commentedPatch worked great for me, thanks! Fixed the issue :D
Comment #13
giorgosk#8 it gives a whitespace warning on applying but it does the job
please commit
Comment #14
szeidler#8 gives me the whitespace warning, too.
It should be fine to commit. Panels, that was facing the same problem, committed the same approach just now: https://www.drupal.org/node/2709521#comment-11938080
Comment #15
utement commented#8 whitespace warning, but it works.
Ready to commit.
Comment #17
boshtian commentedComment #18
boshtian commented