Closed (fixed)
Project:
Configuration Management
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
9 Oct 2012 at 15:30 UTC
Updated:
25 Oct 2012 at 13:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
neoxavier commentedHello here is the patch,
now csta, csto, cimp, cexp, crev drush command has --all option
I also have new command called clist,
I probably will put sync info in clist, but I have not seen the callback function
Comment #2
dagmarHi! Thanks for this patch, here is a bit of feedback.
Would be nice to have two options for this command. One to display only the tracked configurations, and other to display non tracked configurations.
This line is not following the coding standards.
We could display if the configuration is or is not being tracked in another column.
This and the other ifs are not following the coding standards.
Comment #3
neoxavier commentedHello,
thanks for the feedback, can you poin me where can I get the component object? so I can use getStatus function
Comment #4
neoxavier commentedignore this patch, this is not clean
Comment #5
neoxavier commentedcleaner patch.
I decide not to put status in clist at the moment as I've put status in cgt drush command (http://drupal.org/node/1808450). But I will add the status after both patch has been commited. It will be easier for me to build up from that.
Comment #6
neoxavier commentedsorry forget the patch
Comment #7
dagmarComment #8
gdrupal commented@neoxavier this patch looks RTBC for me... not coding standard issues so far... I tested manually all commands, double checking its results in the UI too.... looooooking good
Comment #9
gdrupal commented@neoxavier There is a few indent missing in lines after the "if" Coder was missing that... I use mostly NB to format my code following this... http://drupal.org/node/1019816 if that could be a help for you.
Comment #10
neoxavier commentedHello,
thanks for the feedback
actually I use NB plug in as well. Dunno why it happened. Maybe because I fix it during lunch
here is the identation fix
Comment #11
dagmarYou forgot this :)
Also, remember to change the status to "Needs Review" when you provide a new patch.
Comment #12
neoxavier commentedHello,
ah ya, after midnight fix..
thank you for reminding me..
here is the new patch
Comment #13
gdrupal commentedNow it looks RTBC
Comment #14
dagmarAwesome! Committed: 690e7ee
I created a Follow up for this issue: #1809908: drush ctso --all doesn't display the right number of untracked configurations