When you are adding an additional module for the Modules Installed plugin, you should be able to supply a display name for your additional module. It should default to the capitalized machine name.

So for instance if I enter
search_by_page-7.x-1.2
the display name should default to "Search by page", but I should be able to change it to "Search by Page" if I want to.

Comments

tamasd’s picture

tamasd commented
Version: » 7.x-1.x-dev
Assigned: Unassigned » tamasd
Status: Active » Needs review

Pushed: b93fbbba669fd35e9d58147c2550b43593bb5080.

Note, that this will erase the previous settings of the "enabled" plugin.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

I cannot save my Text Filter settings now. I entered:
bogus_7.x-3.2
And I got a validation error:
Invalid module name or version.

This was independent of whether I had a display name or I didn't have a display name entered.

tamasd’s picture

tamasd commented
Status: Needs work » Needs review

The validation is the same as before. However you have to write bogus-7.x-3.2 instead of bogus_7.x-3.2.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Duh! Sorry about the false alarm.

So the machine name is working now... but I think the default should be changed.

If I enter (in a condition or in the additional modules area in the text format) a module name like long_module_name, and I don't provide a machine name, I think the default should be either "Long Module Name" or "Long module name" (i.e., replace the underscores with spaces). It is currently defaulting to "Long_module_name".

tamasd’s picture

tamasd commented

Fixed: b3d28fef54938c7fce48e6cd737bdf7ee2ab16ee.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks, this is now working fine.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.