Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Conditional Flags works fine with Javascript flags, but if you change link type to normal or confirmation form it just doesn't work.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | conditional_flags-2129977-4.patch | 2.67 KB | danepowell |
Comments
Comment #1
sebas5384 commentedI see this as a feature request, so i will love to review patches :)
Just wondering if even the javascript didn't work for other link types, the reaction unflag/flag still applies in the background, can you tell me?
Cheers!
Comment #2
Plazmus commentedHey, thank for your reply. If that's how it suppose to work, then I would suggest to put that on the module's description page.
I can't provide a patch as I am not a developer.
It is worth to mention that we can actually achieve the same functionality with Rules, but this time only with no javascript links, but I guess it's not that elegant solution.
Comment #3
sebas5384 commentedYes! I'm going to write about this in the description page, thanks for the suggestion!
Comment #4
danepowell commentedThe problem is that Flag removed hook_flag() in D7 and replaced it with hook_flag_flag() and hook_flag_unflag(). The attached patch fixes this.
Comment #5
sebas5384 commentedHey Dane! thanks for the patch.
I'll review it, and if it works, then i make an other release ;)
Cheers!