In order for Drupal to see a module, the name of the .info and .module must match. The following patch addresses that using community_funded_ hook prefix. You could just as easily use communityfunded_.

CommentFileSizeAuthor
#2 2552805-rename_files.patch1.77 KBkreynen

Comments

kreynen created an issue. See original summary.

kreynen’s picture

kreynen commented
StatusFileSize
new 2552805-rename_files.patch1.77 KB
lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Active » Needs review

Since there is a patch, this should move to needs review.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs review » Needs work

The patch appears to be deleting a file and not renaming anything as suggested in the Issue Summary.

kreynen’s picture

kreynen commented

We currently run a fork of this at CU. https://github.com/CuBoulder/packages_base/tree/dev/contrib/modules/comm...

Or really, the original module that we helped Community Funded develop and someone who didn't understand Drupal committed here. I've been really clear with the dev team at Community Funded that the way their are handling query strings isn't The Drupal Way™ and that makes it difficult to install this on a site that does anything else, but got no response.

My concern is that I don't want to be running forks, projects that have < 1.0 release that aren't being reviewed for security issues, and projects that aren't alerting us of security issues when they are reported in production.

I'm hoping to get a few of the universities who are using both Drupal and Community Funded to help make this case to Community Funded. If Community Funded is going to sell this service as having Drupal support, I'd like to to actually be supported on Drupal.org as a full project with proper releases.

Hopefully that makes sense.

communityfunded’s picture

communityfunded commented

Hi Guys,

This is Matt at Community Funded. We are definitely not drupal developers. We still do not have any other universities using drupal and CF.

I still want to be able to help you. I sincerely apologize for not paying more attention to this project.

What are the next steps? Is there a UI for me to be able to review/approve this patch that you have created?

Thank You

Matt

kreynen’s picture

kreynen commented

What about https://crowdfunding.uchicago.edu/? Looking at the HTML, that's Crowd Funded running on Drupal. I've reached out to @zaphoyd about that, but it isn't a site in their standard service. Still trying to figure out who's responsible for that site.

Drupal's git implementation is not like GitHub with PRs. Drupal still uses the old school patch process. The biggest argument to keeping patches has been that it avoids improvement to an existing PR getting stuck when developers "tune out" of a project for a period of time. With patches, anyone can jump in and improve the patch and update it to chase the project's head. Of course, using patches also requires

Drupal does support automated testing of patches and has made a lot of improvements in that area in just the last year.

You can also use https://simplytest.me/ to test a project with a patch.

  • owenpm3 committed 6d685cb on 7.x-1.x 
    Issue #2552805 by owenpm3: File naming changes to support Drupal module...
owenpm3’s picture

owenpm3 commented
Status: Needs work » Fixed
owenpm3’s picture

owenpm3 commented
Version: » 7.x-1.x-dev

  • owenpm3 committed 6d685cb on 8.x-1.x 
    Issue #2552805 by owenpm3: File naming changes to support Drupal module...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.