Message notify switch from Advancedqueue to Drupal's core queue system. Let's investigate what (if anything) Commons must do to implement this change.

Comments

ezra-g’s picture

Issue tags: -commons 7.x-3.8 radar +commons 7.x-3.9 radar
ezra-g’s picture

Assigned: Unassigned » ezra-g
ezra-g’s picture

Status: Active » Fixed

Looks like this is already done for us with #1932326: Use core's Queue instead of advacned-queue, which is included in Message Subscribe 7.x-1.0-rc1.

I'll make a note to add instructions to the Commons release notes directing people to uninstall the Advancedqueue module.

ezra-g’s picture

And of course, removing AdvancedQueue from the Commons download: http://drupalcode.org/project/commons.git/commit/f32b0a6.

ezra-g’s picture

I forgot to include commons.info in my commit. Followup commit: http://drupalcode.org/project/commons.git/commit/e3c0105.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

guruslot’s picture

New update to Commons 3.9 lead to empty Views - Site Activity and Group Activity (after execution an update.php)

guruslot’s picture

Is it necessarily to revert message_type during the upgrade to 3.9?

WebSinPat’s picture

@guruslot, I just did 3.8->3.9 upgrade and my views are not empty. Though I did run into this issue #2195755: Advancedqueue Error upgrading from 3.8 to 3.9. Not sure if you might be running into something similar? Also, I'm pretty sure message types were automatically reverted during the upgrade (I suspect this because some of my configurations were overwritten without me myself doing any feature reverts).
Not sure if any of this is helpful but...

guruslot’s picture

@WebSinPat, have you run an update?

Update reverts all messages, i.e.:

/* Revert Message types to use the correct title field token.
function commons_update_3112() {
$revert = array(
'commons_wikis' => array('message_type'),
'commons_q_a' => array('message_type'),
'commons_posts' => array('message_type'),
'commons_notify' => array('message_type'),
'commons_like' => array('message_type'),
'commons_activity_streams' => array('message_type'),
);
features_revert($revert);
return array();
}

guruslot’s picture

I got it.

'message:field-target-nodes:0:title' need to be replaced with 'message:field-target-nodes:0:title_field'
Reverting to defaults in my case makes a loose of all translated messages which is not ok.

So, if you need to update on multilanguage setup just skip this reverting by commenting within commons.install feature reverting code.
Tokens could be replaced directly within a database by a MySQL query.

Maybe this will be helpful for someone.

WebSinPat’s picture

Ah yes, @guruslot. I knew the code had done a features_revert and switched to title_field, but wasn't sure where. commons.install is it.

Yes, on my site I also have configurations to the message_types (nor for translations but for several other issues) and every time I upgrade they get overwritten by features_revert. I had not thought of your solution of fixing in the database.
THe solution I am experimenting with is to create a patch that modifies the features that set up message types, that way my configurations will be in code. So workflow would be after upgrade commons and revert features.message_type, then apply my patch and revert features.message_type again.
Message types are configured in the following features as far as I can tell:
drush fr commons_q_a.message_type commons_wikis.message_type commons_posts.message_type commons_follow_user.message_type commons_activity_streams.message_type commons_notify.message_type