Currently we require drupal/xero "~1.2" which is incompatible with 2.x and so unusable on any new project.

CommentFileSizeAuthor
#9 interdiff-3153297-5-8.txt2 KBmradcliffe
#9 3153297-8.patch13.22 KBmradcliffe
#6 interdiff-3153297-4-5.txt4.25 KBjonathanshaw
#6 3153297-5.patch12.53 KBjonathanshaw
#4 3153297-4.patch9.6 KBmradcliffe
#3 3153297-3.patch9.6 KBmradcliffe

Comments

jonathanshaw created an issue. See original summary.

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented

I'm thinking "~1.2 || ~2.0" but I've not been able to test this yet.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3153297-3.patch9.6 KB

Sorry I didn't get to this sooner. I went ahead and tried to incorporate some deprecation fixes as well.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new 3153297-4.patch9.6 KB

phpstorm suggested something bad in composer.json.

Status: Needs review » Needs work

The last submitted patch, 4: 3153297-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
StatusFileSize
new 3153297-5.patch12.53 KB
new interdiff-3153297-4-5.txt4.25 KB

I think this might fix the tests.

I also stumbled across OrderKernelTestBase while doing this and implemented that for future-proofing, and fixed a coding standard.

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Status: Needs work » Needs review

Doh

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented

I tried to fix one of the things preventing the branch from passing in my patch, but I've no idea why the other is a "risky test".

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new 3153297-8.patch13.22 KB
new interdiff-3153297-5-8.txt2 KB

The risky test is because that test isn't asserting anything directly. It's fine.

Commerce updated again and a kernel base test got removed.

  • mradcliffe committed bbdac60 on 8.x-1.x 
    Issue #3153297 by mradcliffe, jonathanshaw: Updates composer.json to...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed 
+++ b/tests/src/Unit/Plugin/QueueWorker/CommerceXeroProcessTest.php
@@ -182,7 +180,7 @@ class CommerceXeroProcessTest extends UnitTestCase {
+    $worker = CommerceXeroProcess::create($this->container, $configuration, 'commerce_xero_process', $plugin_defintion);

Another typo too. Fixed on commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.