Problem/Motivation

Recently encountered an issue where a simple misconfiguration on a webform was preventing the webform_commerce_order handler from executing successfully.

Steps to reproduce

If the Webform confirmation admin/structure/webform/manage/webform_id/settings/confirmation is not set to none, the commerce order handler may not fire correctly.
webform confirmation configuration settings

Proposed resolution

Update the readme to add a bullet

  • In the handlers admin screen (admin/structure/webform/manage/webform_id/handlers) you should be able to add a "Commerce Handler" one.
  • In the confirmation admin screen (admin/structure/webform/manage/webform_id/settings/confirmation) you should set the confirmation to `None` to allow for the commerce_webform_order handler to take priority.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3223821-3.patch4.67 KBfacine
webform-confirmation-config.png233.38 KBwalangitan

Comments

walangitan created an issue. See original summary.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Title: Update README to suggest updating webform confirmation configuration to explicitly use the handler. » Improve information regarding confirmation type
Version: 2.0.0-beta1 » 2.x-dev
Component: Documentation » User interface
Category: Feature request » Task

Thanks @walangitan for the suggestion, @facine and I have discussed this and this is what we're going to do, rather than improve the README file (which you're more than welcome to provide a patch/MR for in #3044297: Update README), we're going to improve the wording of the module settings:

- On the handler itself the option to redirect will be renamed to "Override confirmation type"
- On the confirmation type settings (screenshot attached by @walangitan), we're adding a warning there when said override confirmation type setting is enabled on the handler.

Said this, with the current status of the module, if you disable the redirect on your handler, you can use any confirmation type you want.

facine’s picture

facine commented
Status: Active » Needs review
StatusFileSize
new 3223821-3.patch4.67 KB
facine’s picture

facine commented
Version: 2.x-dev » 3.x-dev
Status: Needs review » Fixed

Fixed, thank you!

Please download and review the latest dev release.

  • facine committed 5586846d on 3.x 
    Issue #3223821 by facine, walangitan, pcambra: Improve information...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.